Alternative syntax for element.animate list of keyframes

third_party/WebKit/Source/core/animation/EffectInput.h

Index: third_party/WebKit/Source/core/animation/EffectInput.h
diff --git a/third_party/WebKit/Source/core/animation/EffectInput.h b/third_party/WebKit/Source/core/animation/EffectInput.h
index 4d80d5f0d2b83c970344b4adcc0f141368baf593..351da2c00c08a34f12913172d31da82bc1caa617 100644
--- a/third_party/WebKit/Source/core/animation/EffectInput.h
+++ b/third_party/WebKit/Source/core/animation/EffectInput.h
@@ -17,6 +17,7 @@ class EffectModelOrDictionarySequenceOrDictionary;
 class Dictionary;
 class Element;
 class ExceptionState;
+class StringKeyframe;
 
 class CORE_EXPORT EffectInput {
     STATIC_ONLY(EffectInput);
@@ -25,7 +26,18 @@ public:
     static EffectModel* convert(Element*, const EffectModelOrDictionarySequenceOrDictionary&, ExceptionState&);
 
 private:
-    static EffectModel* convert(Element*, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState&);
+    // keyframesSpecifiedAsList should be
+    // - true if the keyframeDictionaryVector was specified as a list originally (we entered this function from the DictionarySequence case of
+    //       EffectModelOrDictionarySequenceOrDictionary above)
+    // - false if we were in the single Dictionary case (handled by the function below) and needed to fall back to the sequence case instead
+    static EffectModel* convert(Element*, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState&, bool keyframesSpecifiedAsList);
+
+    static EffectModel* convert(Element*, const Dictionary& keyframeDictionary, ExceptionState&);
+
+    // Returns true if the property passed in is a compositable property.
+    static bool setKeyframeValue(Element*, StringKeyframe&, const String& property, const String& value);
+
+    static EffectModel* createEffectModelFromKeyframes(Element*, const Vector<RefPtr<StringKeyframe>>& keyframes, bool encounteredCompositableProperty, ExceptionState&);

[alancutter (OOO until 2018), 2016/02/25 06:52:27]

No need for private static methods, these can live in an anonymous namespace in
the cpp file. This will probably reduce the number of includes and forward
declarations in the header file.

[suzyh_UTC10 (ex-contributor), 2016/02/26 04:35:31]

Done.

 };
 
 } // namespace blink