third_party/WebKit/Source/core/animation/EffectInput.h - Issue 1720403002: Alternative syntax for element.animate list of keyframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/EffectInput.h

Issue 1720403002: Alternative syntax for element.animate list of keyframes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@animations-keyframeeffect-api

Patch Set: Additional (mismatched-length-list) test; ensure offset is initialized Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/web-animations-api/w3c/out-of-order-keyframes.html ('k') | third_party/WebKit/Source/core/animation/EffectInput.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/EffectInput.h

diff --git a/third_party/WebKit/Source/core/animation/EffectInput.h b/third_party/WebKit/Source/core/animation/EffectInput.h

index 4d80d5f0d2b83c970344b4adcc0f141368baf593..9ebef7497db7082f878971ddc4c92325920aa210 100644

--- a/third_party/WebKit/Source/core/animation/EffectInput.h

+++ b/third_party/WebKit/Source/core/animation/EffectInput.h

@@ -26,6 +26,7 @@ public:

private:

static EffectModel* convert(Element*, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState&);

+ static EffectModel* convert(Element*, const Dictionary& keyframeDictionary, ExceptionState&);

};

} // namespace blink