third_party/WebKit/Source/core/animation/EffectInputTest.cpp - Issue 1720403002: Alternative syntax for element.animate list of keyframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/EffectInputTest.cpp

Issue 1720403002: Alternative syntax for element.animate list of keyframes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@animations-keyframeeffect-api

Patch Set: Change to error types and how offset/composite are handled, plus minor fixes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/animation/EffectInputTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/EffectInputTest.cpp b/third_party/WebKit/Source/core/animation/EffectInputTest.cpp

index 9a3676c60710ac7cac524375e4f8fe48ab7d593b..73a4b97249c81333aab7ec1d956014f43590f36f 100644

--- a/third_party/WebKit/Source/core/animation/EffectInputTest.cpp

+++ b/third_party/WebKit/Source/core/animation/EffectInputTest.cpp

@@ -73,7 +73,7 @@ TEST_F(AnimationEffectInputTest, UnsortedOffsets)

EffectInput::convert(element.get(), EffectModelOrDictionarySequenceOrDictionary::fromDictionarySequence(jsKeyframes), exceptionState);

EXPECT_TRUE(exceptionState.hadException());

- EXPECT_EQ(InvalidModificationError, exceptionState.code());

+ EXPECT_EQ(V8TypeError, exceptionState.code());

}

TEST_F(AnimationEffectInputTest, LooslySorted)

@@ -144,7 +144,7 @@ TEST_F(AnimationEffectInputTest, Invalid)

EffectInput::convert(element.get(), EffectModelOrDictionarySequenceOrDictionary::fromDictionarySequence(jsKeyframes), exceptionState);

EXPECT_TRUE(exceptionState.hadException());

- EXPECT_EQ(InvalidModificationError, exceptionState.code());

+ EXPECT_EQ(V8TypeError, exceptionState.code());

}

} // namespace blink

« third_party/WebKit/Source/core/animation/EffectInput.cpp ('K') | « third_party/WebKit/Source/core/animation/EffectInput.cpp ('k') | no next file » | no next file with comments »