Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1720343002: Attempt decoder fallback when the first decode call fails. (Closed)

Created:
4 years, 10 months ago by DaleCurtis
Modified:
4 years, 6 months ago
Reviewers:
tguilbert
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@resume_zero
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt decoder fallback when the first decode call fails. There are several instances where a GPU video decoder will fail on the first decode even though it reported successfull initialization. In these cases try to fallback to a software decoder if possible. This works by queuing the first buffers sent to Decode() before any output callbacks have occurred. If decode fails before output is received it will attempt to reselect a decoder. If this is successful the pending decoders will be fed in at an appropriate rate to the new decoder. Pending decode callbacks from the previous decoder are invalidated by way of a sequence token. BUG=??? TEST=manual...

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -7 lines) Patch
M media/filters/decoder_stream.h View 2 chunks +8 lines, -1 line 0 comments Download
M media/filters/decoder_stream.cc View 7 chunks +35 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (4 generated)
DaleCurtis
Needs a test and existing tests to be fixed, but otherwise works. Do we have ...
4 years, 10 months ago (2016-02-23 04:17:22 UTC) #2
DaleCurtis
Just realized this should also let us set 4k+ decode limits on our hardware decoders ...
4 years, 9 months ago (2016-03-14 23:21:05 UTC) #3
DaleCurtis
4 years, 9 months ago (2016-03-14 23:21:25 UTC) #5
cc:tguilbert who was going to look into this as FYI.

Powered by Google App Engine
This is Rietveld 408576698