Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 172033002: Remove WrapperTypeTraits (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 10 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove WrapperTypeTraits WrapperTypeTraits is unnecessary. This CL replaces WrapperTypeTraits<X>::wrapperTypeInfo() with &V8X::wrapperTypeInfo, and removes WrapperTypeTraits completely. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -249 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython2.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython3.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestSVG.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsCustom.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/v8/WrapperTypeInfo.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/bindings/v8/custom/V8DataViewCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8Float32ArrayCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8Float64ArrayCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8Int16ArrayCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8Int32ArrayCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8Int8ArrayCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8Uint16ArrayCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8Uint32ArrayCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8Uint8ArrayCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8Uint8ClampedArrayCustom.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
haraken
PTAL
6 years, 10 months ago (2014-02-19 06:44:33 UTC) #1
dcarney
lgtm
6 years, 10 months ago (2014-02-19 07:58:43 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-19 08:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/172033002/1
6 years, 10 months ago (2014-02-19 08:07:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 11:24:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=27830
6 years, 10 months ago (2014-02-19 11:24:11 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-19 11:39:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/172033002/1
6 years, 10 months ago (2014-02-19 11:39:53 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 11:40:29 UTC) #9
Message was sent while issue was closed. 
Change committed as 167409

Powered by Google App Engine
This is Rietveld 408576698