Chromium Code Reviews
Help | Chromium Project | Sign in
(16)

Issue 172032: First cut for a FreeBSD port - much still not working (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by Ben Laurie (Chromium)
Modified:
5 years, 10 months ago
CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, John Grabowski, awong, darin (slow to review), scherkus (not reviewing)
Visibility:
Public.

Description

Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set but not OS_WIN. Added USE_X11. Set when OS_LINUX or OS_FREEBSD is set. Added USE_BASE_DATA_PACK for base::DataPack usage, set for OS_MACOSX, OS_LINUX or OS_FREEBSD. Added USE_NSS for ... nss (for crypto). Windows and MacOS use platform-specific libraries. All of the above cause slightly odd formulations like: #if defined(OS_WIN) ... #elif defined(USE_BASE_DATA_PACK) ... #endif Possibly should also define USE_DLL_FOR_DATA, etc? Or something? Wrapped various references to struct stat64 and stat64() to use struct stat and stat() for FreeBSD - but a "man stat64" on Linux suggests that we could do the same thing for at least Linux, too, and perhaps eliminate the wrapper?

Patch Set 1 #

Total comments: 20

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Total comments: 8

Patch Set 10 : '' #

Total comments: 1

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Total comments: 8

Patch Set 14 : '' #

Total comments: 10

Patch Set 15 : '' #

Total comments: 1

Patch Set 16 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -100 lines) Patch
M app/app.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M app/resource_bundle.h View 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +5 lines, -5 lines 0 comments Download
M base/base.gyp View 4 5 6 7 8 9 10 11 12 13 14 15 10 chunks +28 lines, -15 lines 1 comment Download
M base/clipboard.h View 5 6 7 8 9 10 11 12 13 14 15 3 chunks +3 lines, -3 lines 0 comments Download
M base/clipboard_linux.cc View 5 6 7 8 9 10 11 12 13 14 15 1 chunk +4 lines, -1 line 0 comments Download
M base/crypto/signature_verifier.h View 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_util_posix.cc View 5 6 7 8 9 10 11 12 13 14 15 8 chunks +28 lines, -15 lines 0 comments Download
M base/gfx/native_widget_types.h View 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +8 lines, -8 lines 0 comments Download
M base/gfx/rect.h View 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +4 lines, -4 lines 0 comments Download
M base/keyboard_codes.h View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M build/build_config.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +21 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +10 lines, -4 lines 0 comments Download
M chrome/common/transport_dib.h View 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +4 lines, -4 lines 0 comments Download
M media/base/media_posix.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +10 lines, -1 line 0 comments Download
M skia/ext/platform_canvas.h View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/platform_device.h View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M third_party/ffmpeg/ffmpeg.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libevent/libevent.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/libxml.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libxslt/libxslt.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M third_party/npapi/bindings/npapi.h View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M webkit/build/rule_gperf.py View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +5 lines, -2 lines 0 comments Download
M webkit/glue/plugins/nphostapi.h View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_lib.cc View 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/plugins/plugin_list.h View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.h View 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/webcursor.h View 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webframe_impl.cc View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webframeloaderclient_impl.cc View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.cc View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 8 chunks +10 lines, -7 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 36 (0 generated)
Amanda Walker
+mark for better gyp review http://codereview.chromium.org/172032/diff/1/9 File third_party/ffmpeg/ffmpeg.gyp (right): http://codereview.chromium.org/172032/diff/1/9#newcode12 Line 12: ['OS!="freebsd"', {'sources/': [['exclude', ...
7 years, 7 months ago (2009-08-16 20:02:09 UTC) #1
tony
For reference, someone started an open bsd port here (it was never committed): http://codereview.chromium.org/118469 The ...
7 years, 7 months ago (2009-08-17 17:22:50 UTC) #2
Mark Mentovai
Adding ar all over the place seems conceptually distinct from this change. Can you split ...
7 years, 7 months ago (2009-08-17 20:13:40 UTC) #3
brettw (plz ping after 24h)
I'm very scared of this. We have hundreds of places where OS_LINUX appears in our ...
7 years, 7 months ago (2009-08-17 20:32:25 UTC) #4
Ben Laurie (Chromium)
Fresh patch coming soon, but some comments in the meantime... On Mon, Aug 17, 2009 ...
7 years, 7 months ago (2009-08-17 20:38:07 UTC) #5
brettw (plz ping after 24h)
Also, this seems like something significant we should get team consensus on whether and how ...
7 years, 7 months ago (2009-08-17 20:38:37 UTC) #6
Ben Laurie (Chromium)
On Mon, Aug 17, 2009 at 9:32 PM, <brettw@chromium.org> wrote: > I'm very scared of ...
7 years, 7 months ago (2009-08-17 20:41:27 UTC) #7
brettw (plz ping after 24h)
If we're going to keep a FreeBSD port, I think we should either convert all ...
7 years, 7 months ago (2009-08-17 20:51:39 UTC) #8
Amanda Walker (Google)
That's what Ben appeared to be doing, actually. --Amanda On Mon, Aug 17, 2009 at ...
7 years, 7 months ago (2009-08-17 20:56:57 UTC) #9
Ben Goodger (Google)
In which case, a CL desc explaining this, or an email to chromium-dev before mystery ...
7 years, 7 months ago (2009-08-17 21:11:21 UTC) #10
Ben Laurie (Chromium)
http://codereview.chromium.org/172032/diff/1/12 File chrome/chrome.gyp (right): http://codereview.chromium.org/172032/diff/1/12#newcode2930 Line 2930: ['OS=="linux" or OS=="freebsd"', { On 2009/08/17 20:13:40, Mark ...
7 years, 7 months ago (2009-08-17 21:24:22 UTC) #11
Ben Laurie (Chromium)
Updated! http://codereview.chromium.org/172032
7 years, 7 months ago (2009-08-19 14:13:17 UTC) #12
Amanda Walker
gyp changes look much better. For compile flags, I'd rather have a pattern of "test ...
7 years, 7 months ago (2009-08-19 15:44:32 UTC) #13
brettw (plz ping after 24h)
Have you addressed me & Ben G.'s concerns? (Post to chromium-dev for how we want ...
7 years, 7 months ago (2009-08-19 17:00:11 UTC) #14
Ben Laurie (Chromium)
Updated. Post to -dev coming shortly. CL description once people are happy with state of ...
7 years, 7 months ago (2009-08-19 18:28:42 UTC) #15
wtc
I reviewed the non-GUI changes to base. http://codereview.chromium.org/172032/diff/3383/2309 File base/base_paths.h (right): http://codereview.chromium.org/172032/diff/3383/2309#newcode17 Line 17: #include ...
7 years, 7 months ago (2009-08-27 17:25:54 UTC) #16
sky
http://codereview.chromium.org/172032/diff/2330/2339 File build/build_config.h (right): http://codereview.chromium.org/172032/diff/2330/2339#newcode19 Line 19: # define OS_MACOSX 1 I don't believe we ...
7 years, 7 months ago (2009-08-27 18:35:15 UTC) #17
brettw (plz ping after 24h)
I agree with Scott with the spaces. I can see why people do that, but ...
7 years, 7 months ago (2009-08-27 19:23:59 UTC) #18
Ben Laurie (Chromium)
On Thu, Aug 27, 2009 at 6:25 PM, <wtc@chromium.org> wrote: > I reviewed the non-GUI ...
7 years, 7 months ago (2009-08-27 19:44:21 UTC) #19
Ben Laurie (Chromium)
On Thu, Aug 27, 2009 at 7:35 PM, <sky@chromium.org> wrote: > > http://codereview.chromium.org/172032/diff/2330/2339 > File ...
7 years, 7 months ago (2009-08-27 19:48:00 UTC) #20
wtc
http://codereview.chromium.org/172032/diff/3383/2310 File base/process_util.h (right): http://codereview.chromium.org/172032/diff/3383/2310#newcode17 Line 17: #include <dirent.h> <dirent.h> is in Single Unix Specification ...
7 years, 7 months ago (2009-08-27 19:56:39 UTC) #21
Ben Laurie (Chromium)
On Thu, Aug 27, 2009 at 8:23 PM, <brettw@chromium.org> wrote: > I agree with Scott ...
7 years, 7 months ago (2009-08-27 23:16:56 UTC) #22
Ben Laurie (Chromium)
Updated.
7 years, 7 months ago (2009-08-28 06:25:52 UTC) #23
brettw (plz ping after 24h)
http://codereview.chromium.org/172032/diff/7029/7069 File base/clipboard_linux.cc (right): http://codereview.chromium.org/172032/diff/7029/7069#newcode122 Line 122: targets[i].target = static_cast<gchar *>(malloc(iter->first.size() + 1)); We normally ...
7 years, 7 months ago (2009-08-28 16:42:44 UTC) #24
Ben Laurie (Chromium)
http://codereview.chromium.org/172032/diff/7029/7069 File base/clipboard_linux.cc (right): http://codereview.chromium.org/172032/diff/7029/7069#newcode122 Line 122: targets[i].target = static_cast<gchar *>(malloc(iter->first.size() + 1)); On 2009/08/28 ...
7 years, 7 months ago (2009-08-28 17:54:59 UTC) #25
Ben Laurie (Chromium)
Updated.
7 years, 7 months ago (2009-08-28 17:55:53 UTC) #26
wtc
Ben, I reviewed the following files in Patch Set 14. They look good to me. ...
7 years, 7 months ago (2009-08-28 18:31:52 UTC) #27
Ben Laurie (Chromium)
wtc: thanks for that, excellent suggestion. I have moved those files here: http://codereview.chromium.org/180037 The next ...
7 years, 7 months ago (2009-08-29 18:57:55 UTC) #28
Ben Laurie (Chromium)
Updated.
7 years, 7 months ago (2009-08-29 19:00:46 UTC) #29
wtc
http://codereview.chromium.org/172032/diff/2409/2447 File base/process_util.h (right): http://codereview.chromium.org/172032/diff/2409/2447#newcode16 Line 16: #elif defined(OS_POSIX) && !defined(OS_MACOSX) On 2009/08/29 18:57:55, benl ...
7 years, 7 months ago (2009-08-29 19:09:30 UTC) #30
Amanda Walker
LGTM. The revised #ifdef approach is much more readable.
7 years, 7 months ago (2009-09-01 20:59:24 UTC) #31
Amanda Walker
LGTM, one optional nit :-). http://codereview.chromium.org/172032/diff/7076/6085 File base/clipboard.h (right): http://codereview.chromium.org/172032/diff/7076/6085#newcode170 Line 170: #if defined(OS_WIN) || ...
7 years, 7 months ago (2009-09-01 22:03:07 UTC) #32
Ben Laurie (Chromium)
On Wed, Sep 2, 2009 at 10:11 PM, <thestig@chromium.org> wrote: > > http://codereview.chromium.org/172032/diff/7076/6061 > File ...
7 years, 6 months ago (2009-09-02 22:11:24 UTC) #33
Nico
http://codereview.chromium.org/172032/diff/14001/14026 File base/base.gyp (right): http://codereview.chromium.org/172032/diff/14001/14026#newcode401 Line 401: 'conditions': [ Since this is a python dict, ...
7 years, 6 months ago (2009-09-07 18:32:15 UTC) #34
Ben Laurie (Chromium)
On 2009/09/07 18:32:15, Nico wrote: > http://codereview.chromium.org/172032/diff/14001/14026 > File base/base.gyp (right): > > http://codereview.chromium.org/172032/diff/14001/14026#newcode401 > ...
7 years, 6 months ago (2009-09-13 16:29:08 UTC) #35
Ben Laurie (Chromium)
7 years, 6 months ago (2009-09-13 17:01:51 UTC) #36
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46