Ctrl+Backspace should clear inline suggested autocomplete text after caret al...

chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Index: chrome/browser/autocomplete/autocomplete_edit_view_win.cc
===================================================================
--- chrome/browser/autocomplete/autocomplete_edit_view_win.cc	(revision 23046)
+++ chrome/browser/autocomplete/autocomplete_edit_view_win.cc	(working copy)
@@ -1817,6 +1817,13 @@
       return true;
 
     case VK_BACK: {
+      // On Ctrl+Backspace, the default Windows behavior is to delete the
+      // previous word, however this leaves behind the inline autocomplete
+      // suggestion text. Here we clear the suggestion text and place the caret
+      // at the end of the user typed text.
+      if (GetKeyState(VK_CONTROL) < 0)

[Peter Kasting, 2009/08/16 21:59:04]

This approach isn't right.

First, you need to have this happen after rejecting ALT.  Second, all changes
need to happen inside a single ScopedFreeze.  Third, you should not add a
user_text() accessor to the model.  Fourth, and most crucially, this won't fix
the case where the user selects some part of the permanent text and hits
ctrl-backspace.

Basically, to fix this correctly, you need to completely re-implement
ctrl-backspace yourself.  This is way too much effort to be worth it, so I
recommend punting the bug.  This bug should get fixed someday when we replace
CRichEditCtrl with a WebCore edit field.

+        SetWindowTextAndCaretPos(model_->user_text(),
+                                 model_->user_text().length());
       if ((flags & KF_ALTDOWN) || model_->is_keyword_hint() ||
           model_->keyword().empty())
         return false;