Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 172029: Ctrl+Backspace should clear inline suggested autocomplete text after caret al... (Closed)

Created:
11 years, 4 months ago by pierre.lafayette
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Ctrl+Backspace should clear inline suggested autocomplete text after caret along with user written word. BUG=18224 TEST=Type a URL to get the inline autocomplete suggestion and hit Ctrl+Backspace. It should clear the suggested input as well as user entered text.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
pierre.lafayette
11 years, 4 months ago (2009-08-16 05:47:55 UTC) #1
Peter Kasting
11 years, 4 months ago (2009-08-16 21:59:04 UTC) #2
http://codereview.chromium.org/172029/diff/1002/1004
File chrome/browser/autocomplete/autocomplete_edit_view_win.cc (right):

http://codereview.chromium.org/172029/diff/1002/1004#newcode1824
Line 1824: if (GetKeyState(VK_CONTROL) < 0)
This approach isn't right.

First, you need to have this happen after rejecting ALT.  Second, all changes
need to happen inside a single ScopedFreeze.  Third, you should not add a
user_text() accessor to the model.  Fourth, and most crucially, this won't fix
the case where the user selects some part of the permanent text and hits
ctrl-backspace.

Basically, to fix this correctly, you need to completely re-implement
ctrl-backspace yourself.  This is way too much effort to be worth it, so I
recommend punting the bug.  This bug should get fixed someday when we replace
CRichEditCtrl with a WebCore edit field.

Powered by Google App Engine
This is Rietveld 408576698