Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: ui/base/material_design/material_design_controller.cc

Issue 1720273002: Set material hybrid by default on ChromeOS touch devices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gyp/gn changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/BUILD.gn ('k') | ui/base/ui_base.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "ui/base/material_design/material_design_controller.h" 9 #include "ui/base/material_design/material_design_controller.h"
10 #include "ui/base/ui_base_switches.h" 10 #include "ui/base/ui_base_switches.h"
11 11
12 #if defined(OS_CHROMEOS) 12 #if defined(OS_CHROMEOS)
13 #include "base/strings/string_util.h" 13 #include "ui/base/touch/touch_device.h"
14 #include "base/sys_info.h" 14 #include "ui/events/devices/device_data_manager.h"
15
16 #if defined(USE_OZONE)
17 #include <fcntl.h>
18
19 #include "base/files/file_enumerator.h"
20 #include "ui/events/ozone/evdev/event_device_info.h"
21 #endif // defined(USE_OZONE)
22
15 #endif // defined(OS_CHROMEOS) 23 #endif // defined(OS_CHROMEOS)
16 24
17 namespace ui { 25 namespace ui {
18 26
19 bool MaterialDesignController::is_mode_initialized_ = false; 27 bool MaterialDesignController::is_mode_initialized_ = false;
20 28
21 MaterialDesignController::Mode MaterialDesignController::mode_ = 29 MaterialDesignController::Mode MaterialDesignController::mode_ =
22 MaterialDesignController::Mode::NON_MATERIAL; 30 MaterialDesignController::Mode::NON_MATERIAL;
23 31
24 MaterialDesignController::Mode MaterialDesignController::GetMode() { 32 MaterialDesignController::Mode MaterialDesignController::GetMode() {
25 if (!is_mode_initialized_) 33 if (!is_mode_initialized_)
26 InitializeMode(); 34 InitializeMode();
27 CHECK(is_mode_initialized_); 35 CHECK(is_mode_initialized_);
28 return mode_; 36 return mode_;
29 } 37 }
30 38
31 bool MaterialDesignController::IsModeMaterial() { 39 bool MaterialDesignController::IsModeMaterial() {
32 return GetMode() == Mode::MATERIAL_NORMAL || 40 return GetMode() == Mode::MATERIAL_NORMAL ||
33 GetMode() == Mode::MATERIAL_HYBRID; 41 GetMode() == Mode::MATERIAL_HYBRID;
34 } 42 }
35 43
36 MaterialDesignController::Mode MaterialDesignController::DefaultMode() { 44 MaterialDesignController::Mode MaterialDesignController::DefaultMode() {
37 #if defined(OS_CHROMEOS) 45 #if defined(OS_CHROMEOS)
38 // TODO(tdanderson): Enable hybrid by default for touchscreen devices. 46 if (DeviceDataManager::HasInstance() &&
39 // See crbug.com/588880. 47 DeviceDataManager::GetInstance()->device_lists_complete()) {
40 const std::string board = base::SysInfo::GetLsbReleaseBoard(); 48 return GetTouchScreensAvailability() == TouchScreensAvailability::ENABLED ?
41 if (base::StartsWith(board, "link", base::CompareCase::SENSITIVE) || 49 Mode::MATERIAL_HYBRID : Mode::MATERIAL_NORMAL;
42 base::StartsWith(board, "veyron_minnie", base::CompareCase::SENSITIVE) ||
43 base::StartsWith(board, "samus", base::CompareCase::SENSITIVE)) {
44 return Mode::MATERIAL_HYBRID;
45 } 50 }
51
52 #if defined(USE_OZONE)
53 base::FileEnumerator file_enum(
54 base::FilePath(FILE_PATH_LITERAL("/dev/input")), false,
55 base::FileEnumerator::FILES, FILE_PATH_LITERAL("event*[0-9]"));
56 for (base::FilePath path = file_enum.Next(); !path.empty();
57 path = file_enum.Next()) {
58 EventDeviceInfo devinfo;
59 int fd = open(path.value().c_str(), O_RDWR | O_NONBLOCK | O_CLOEXEC);
60 if (fd >= 0) {
61 if (devinfo.Initialize(fd, path) && devinfo.HasTouchscreen()) {
62 close(fd);
63 return Mode::MATERIAL_HYBRID;
64 }
65 close(fd);
66 }
67 }
68 #endif // defined(USE_OZONE)
46 return Mode::MATERIAL_NORMAL; 69 return Mode::MATERIAL_NORMAL;
47 #elif defined(OS_LINUX) 70 #elif defined(OS_LINUX)
48 return Mode::MATERIAL_NORMAL; 71 return Mode::MATERIAL_NORMAL;
49 #else 72 #else
50 return Mode::NON_MATERIAL; 73 return Mode::NON_MATERIAL;
51 #endif // defined(OS_CHROMEOS) 74 #endif // defined(OS_CHROMEOS)
52 } 75 }
53 76
54 void MaterialDesignController::InitializeMode() { 77 void MaterialDesignController::InitializeMode() {
55 #if !defined(ENABLE_TOPCHROME_MD) 78 #if !defined(ENABLE_TOPCHROME_MD)
(...skipping 25 matching lines...) Expand all
81 MaterialDesignController::Mode::NON_MATERIAL); 104 MaterialDesignController::Mode::NON_MATERIAL);
82 is_mode_initialized_ = false; 105 is_mode_initialized_ = false;
83 } 106 }
84 107
85 void MaterialDesignController::SetMode(MaterialDesignController::Mode mode) { 108 void MaterialDesignController::SetMode(MaterialDesignController::Mode mode) {
86 mode_ = mode; 109 mode_ = mode;
87 is_mode_initialized_ = true; 110 is_mode_initialized_ = true;
88 } 111 }
89 112
90 } // namespace ui 113 } // namespace ui
OLDNEW
« no previous file with comments | « ui/base/BUILD.gn ('k') | ui/base/ui_base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698