Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1720243002: Removing Linux specific GnubbyAuthHandler header file. (Closed)

Created:
4 years, 10 months ago by joedow
Modified:
4 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing Linux specific GnubbyAuthHandler header file. This change is a result of feedback from the GnubbyAuthHandler refactoring. Since we will have platform specific implementations of the GnubbyAuthHandler, we should try to have a single header defining the interface and platform specific cc files for the impl. The Linux impl had a header which was used by its unit tests, however I think the test methods could be generic enough that the ForTest() methods make sense to have on the interface as the unittests for each impl will use them. This simplifies the code in the unittests and allows us to hide the platform specific impls in the cc file and remove the platform specific headers. BUG=587298 Committed: https://crrev.com/aceaf12ce102d2551169a6a6265269d33f8462a8 Cr-Commit-Position: refs/heads/master@{#377167}

Patch Set 1 #

Patch Set 2 : Fixing a build break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -117 lines) Patch
M remoting/host/host_mock_objects.h View 2 chunks +3 lines, -0 lines 0 comments Download
M remoting/host/security_key/gnubby_auth_handler.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
D remoting/host/security_key/gnubby_auth_handler_linux.h View 1 chunk +0 lines, -93 lines 0 comments Download
M remoting/host/security_key/gnubby_auth_handler_linux.cc View 4 chunks +67 lines, -4 lines 0 comments Download
M remoting/host/security_key/gnubby_auth_handler_linux_unittest.cc View 8 chunks +14 lines, -19 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
joedow
PTAL! Thanks, Joe
4 years, 10 months ago (2016-02-23 00:13:42 UTC) #2
joedow
Ping!
4 years, 10 months ago (2016-02-23 22:41:57 UTC) #3
Sergey Ulanov
lgtm
4 years, 10 months ago (2016-02-23 23:33:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720243002/20001
4 years, 10 months ago (2016-02-24 00:11:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 01:15:37 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 01:16:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aceaf12ce102d2551169a6a6265269d33f8462a8
Cr-Commit-Position: refs/heads/master@{#377167}

Powered by Google App Engine
This is Rietveld 408576698