Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1720223002: Run no CPU benches in Debug trybots. (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Run no CPU benches in Debug trybots. They seem to just be wasting time on the CQ. Hacking this into nanobench_flags.py makes it easy to back out. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720223002 Committed: https://skia.googlesource.com/skia/+/afe9facc9f7c70ed8a9097ed660bd0bdd31ed14b

Patch Set 1 #

Patch Set 2 : trybot only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M tools/nanobench_flags.json View 1 1 chunk +17 lines, -0 lines 0 comments Download
M tools/nanobench_flags.py View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720223002/1
4 years, 10 months ago (2016-02-22 22:23:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720223002/20001
4 years, 10 months ago (2016-02-22 22:36:04 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-22 22:47:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720223002/20001
4 years, 10 months ago (2016-02-22 22:57:32 UTC) #11
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-22 22:57:33 UTC) #12
mtklein
lgtm
4 years, 10 months ago (2016-02-22 22:58:04 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 23:00:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/afe9facc9f7c70ed8a9097ed660bd0bdd31ed14b

Powered by Google App Engine
This is Rietveld 408576698