Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 1720153002: Revert of Update V8 to version 5.0.60. (Closed)

Created:
4 years, 10 months ago by imcheng (use chromium acct)
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.0.60. (patchset #1 id:1 of https://codereview.chromium.org/1719203002/ ) Reason for revert: Broke Win compile: FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper environment.x86 v8_snapshot_target_run_mksnapshot_3dd7b77762a753f6730b945160370894..rsp ..\..\v8\tools\gyp FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper environment.x86 v8_external_snapshot_target_run_mksnapshot__external__93bfc5871b63718af434b4cbb478e06a..rsp ..\..\v8\tools\gyp ninja: build stopped: subcommand failed. Original issue's description: > Update V8 to version 5.0.60. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/a91392f8..f1990dd3 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/dd748df1ecdea0475ed018c0e5096651f4af0ed8 > Cr-Commit-Position: refs/heads/master@{#376788} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
imcheng (use chromium acct)
Created Revert of Update V8 to version 5.0.60.
4 years, 10 months ago (2016-02-22 21:09:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720153002/1
4 years, 10 months ago (2016-02-22 21:11:39 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2016-02-22 21:11:40 UTC) #4
imcheng (use chromium acct)
4 years, 10 months ago (2016-02-22 21:13:19 UTC) #5
Please disregard. Created another revert patch with my @chromium.org account.

Powered by Google App Engine
This is Rietveld 408576698