Revert of Mojo C++ bindings: support sync methods - part 2

Revert of Mojo C++ bindings: support sync methods - part 2 (patchset #6 id:100001 of https://codereview.chromium.org/1713203002/ )

Reason for revert:
This change is triggering a use-of-uninitialized-value error on the Linux and Chrome OS MSan bots:

https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/7464

Original issue's description:
> Mojo C++ bindings: support sync methods - part 2
>
> This CL introduces the correct re-entrancy behavior: when a sync call is waiting
> for response, allow incoming sync requests on the same thread to re-enter, async
> messages are queued until the sync call completes.
>
> The following will be in future CLs:
> - Support sync calls with associated interfaces.
>
> BUG=577699
>
> Committed: https://crrev.com/083f46638041ba7d7620e47a7f9edf06982a9340
> Cr-Commit-Position: refs/heads/master@{#376751}

TBR=jam@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=577699
Committed: https://crrev.com/8017c320b4215892c4fdf339e75fea5d5a17ce16
Cr-Commit-Position: refs/heads/master@{#376793}

[Reilly Grant (use Gerrit), 2016-02-22 20:13:36]

Created Revert of Mojo C++ bindings: support sync methods - part 2

[Reilly Grant (use Gerrit), 2016-02-22 20:15:05]

==20006==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0xaba009 in find<mojo::Handle>
./out/MSan/../../buildtools/third_party/libc++/trunk/include/__hash_table:2056:37
    #1 0xaba009 in find
./out/MSan/../../buildtools/third_party/libc++/trunk/include/unordered_map:1144:0
    #2 0xaba009 in ContainsKey<std::__1::unordered_map<mojo::Handle,
base::Callback<void (unsigned int)>,
mojo::internal::SyncHandleWatcher::HandleHasher,
std::__1::equal_to<mojo::Handle>, std::__1::allocator<std::__1::pair<const
mojo::Handle, base::Callback<void (unsigned int)> > > >, mojo::Handle>
./out/MSan/../../base/stl_util.h:190:0
    #3 0xaba009 in WatchAllHandles
./out/MSan/../../mojo/public/cpp/bindings/lib/sync_handle_watcher.cc:71:0
    #4 0xa8a1bc in RunSyncHandleWatch
./out/MSan/../../mojo/public/cpp/bindings/lib/connector.cc:241:10
    #5 0xaacba5 in AcceptWithResponder
./out/MSan/../../mojo/public/cpp/bindings/lib/router.cc:143:19
    #6 0xb5390c in Ping
./out/MSan/gen/mojo/public/interfaces/bindings/tests/test_sync_methods.mojom.cc:2296:8
    #7 0x750f9b in TestBody
./out/MSan/../../mojo/public/cpp/bindings/tests/sync_method_unittest.cc:179:3
    #8 0xd926e7 in HandleExceptionsInMethodIfSupported<testing::Test, void>
./out/MSan/../../testing/gtest/src/gtest.cc:2458:12
    #9 0xd926e7 in Run ./out/MSan/../../testing/gtest/src/gtest.cc:2474:0
    #10 0xd94bad in Run ./out/MSan/../../testing/gtest/src/gtest.cc:2656:5
    #11 0xd96417 in Run ./out/MSan/../../testing/gtest/src/gtest.cc:2774:5
    #12 0xdb3e32 in RunAllTests
./out/MSan/../../testing/gtest/src/gtest.cc:4647:11
    #13 0xdb2e05 in
HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>
./out/MSan/../../testing/gtest/src/gtest.cc:2458:12
    #14 0xdb2e05 in Run ./out/MSan/../../testing/gtest/src/gtest.cc:4255:0
    #15 0x81f078 in RUN_ALL_TESTS
./out/MSan/../../testing/gtest/include/gtest/gtest.h:2237:10
    #16 0x81f078 in Run ./out/MSan/../../base/test/test_suite.cc:231:0
    #17 0x858a1c in Run ./out/MSan/../../base/callback.h:394:12
    #18 0x858a1c in LaunchUnitTestsInternal
./out/MSan/../../base/test/launcher/unit_test_launcher.cc:206:0
    #19 0x85824e in LaunchUnitTests
./out/MSan/../../base/test/launcher/unit_test_launcher.cc:445:10
    #20 0x4b2449 in main
./out/MSan/../../mojo/edk/test/run_all_unittests.cc:46:10
    #21 0x7ff32f712ec4 in __libc_start_main
/tmp/tmp.Htw1L27e9P/csu/libc-start.c:287:0
    #22 0x446c18 in _start ??:?

  Uninitialized value was created by a heap deallocation
    #0 0x4b1cf2 in operator delete(void*) ??:?
    #1 0x75179d in ~InterfacePtrState
./out/MSan/../../mojo/public/cpp/bindings/lib/interface_ptr_state.h:53:5
    #2 0x75179d in reset
./out/MSan/../../mojo/public/cpp/bindings/interface_ptr.h:122:0
    #3 0x75179d in operator()
./out/MSan/../../mojo/public/cpp/bindings/tests/sync_method_unittest.cc:176:0
    #4 0x75179d in Run ./out/MSan/../../mojo/public/cpp/bindings/callback.h:98:0
    #5 0xb56c46 in AcceptWithResponder
./out/MSan/gen/mojo/public/interfaces/bindings/tests/test_sync_methods.mojom.cc:2566:7
    #6 0xaae48c in HandleMessageInternal
./out/MSan/../../mojo/public/cpp/bindings/lib/router.cc:227:15
    #7 0xaaba4e in HandleIncomingMessage
./out/MSan/../../mojo/public/cpp/bindings/lib/router.cc:195:10
    #8 0xb59b83 in Accept
./out/MSan/gen/mojo/public/interfaces/bindings/tests/test_sync_methods.mojom.cc:2650:14
    #9 0xa951bd in Accept
./out/MSan/../../mojo/public/cpp/bindings/lib/message_header_validator.cc:73:10
    #10 0xa8896c in ReadSingleMessage
./out/MSan/../../mojo/public/cpp/bindings/lib/connector.cc:315:31
    #11 0xa89beb in ReadAllAvailableMessages
./out/MSan/../../mojo/public/cpp/bindings/lib/connector.cc:341:10
    #12 0xa89beb in OnHandleReadyInternal
./out/MSan/../../mojo/public/cpp/bindings/lib/connector.cc:270:0
    #13 0xa89beb in OnSyncHandleWatcherHandleReady
./out/MSan/../../mojo/public/cpp/bindings/lib/connector.cc:257:0
    #14 0xab9df9 in Run ./out/MSan/../../base/callback.h:394:12
    #15 0xab9df9 in WatchAllHandles
./out/MSan/../../mojo/public/cpp/bindings/lib/sync_handle_watcher.cc:90:0
    #16 0xa8a1bc in RunSyncHandleWatch
./out/MSan/../../mojo/public/cpp/bindings/lib/connector.cc:241:10
    #17 0xaacba5 in AcceptWithResponder
./out/MSan/../../mojo/public/cpp/bindings/lib/router.cc:143:19
    #18 0xb5390c in Ping
./out/MSan/gen/mojo/public/interfaces/bindings/tests/test_sync_methods.mojom.cc:2296:8
    #19 0x750f9b in TestBody
./out/MSan/../../mojo/public/cpp/bindings/tests/sync_method_unittest.cc:179:3
    #20 0xd926e7 in HandleExceptionsInMethodIfSupported<testing::Test, void>
./out/MSan/../../testing/gtest/src/gtest.cc:2458:12
    #21 0xd926e7 in Run ./out/MSan/../../testing/gtest/src/gtest.cc:2474:0
    #22 0xd94bad in Run ./out/MSan/../../testing/gtest/src/gtest.cc:2656:5
    #23 0xd96417 in Run ./out/MSan/../../testing/gtest/src/gtest.cc:2774:5
    #24 0xdb3e32 in RunAllTests
./out/MSan/../../testing/gtest/src/gtest.cc:4647:11
    #25 0xdb2e05 in
HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>
./out/MSan/../../testing/gtest/src/gtest.cc:2458:12
    #26 0xdb2e05 in Run ./out/MSan/../../testing/gtest/src/gtest.cc:4255:0
    #27 0x81f078 in RUN_ALL_TESTS
./out/MSan/../../testing/gtest/include/gtest/gtest.h:2237:10
    #28 0x81f078 in Run ./out/MSan/../../base/test/test_suite.cc:231:0

SUMMARY: MemorySanitizer: use-of-uninitialized-value
(/src/chromium/src/out/MSan/mojo_public_bindings_unittests+0xaba009)

[Reilly Grant (use Gerrit), 2016-02-22 20:15:12]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-02-22 20:16:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720093002/1

[commit-bot: I haz the power, 2016-02-22 20:20:26]

Description was changed from

==========
Revert of Mojo C++ bindings: support sync methods - part 2 (patchset #6
id:100001 of https://codereview.chromium.org/1713203002/ )

Reason for revert:
This change is triggering a use-of-uninitialized-value error on the Linux and
Chrome OS MSan bots:

https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...

Original issue's description:
> Mojo C++ bindings: support sync methods - part 2
> 
> This CL introduces the correct re-entrancy behavior: when a sync call is
waiting
> for response, allow incoming sync requests on the same thread to re-enter,
async
> messages are queued until the sync call completes.
> 
> The following will be in future CLs:
> - Support sync calls with associated interfaces.
> 
> BUG=577699
> 
> Committed: https://crrev.com/083f46638041ba7d7620e47a7f9edf06982a9340
> Cr-Commit-Position: refs/heads/master@{#376751}

TBR=jam@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=577699
==========

to

==========
Revert of Mojo C++ bindings: support sync methods - part 2 (patchset #6
id:100001 of https://codereview.chromium.org/1713203002/ )

Reason for revert:
This change is triggering a use-of-uninitialized-value error on the Linux and
Chrome OS MSan bots:

https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...

Original issue's description:
> Mojo C++ bindings: support sync methods - part 2
> 
> This CL introduces the correct re-entrancy behavior: when a sync call is
waiting
> for response, allow incoming sync requests on the same thread to re-enter,
async
> messages are queued until the sync call completes.
> 
> The following will be in future CLs:
> - Support sync calls with associated interfaces.
> 
> BUG=577699
> 
> Committed: https://crrev.com/083f46638041ba7d7620e47a7f9edf06982a9340
> Cr-Commit-Position: refs/heads/master@{#376751}

TBR=jam@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=577699
==========

[commit-bot: I haz the power, 2016-02-22 20:20:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-22 20:21:17]

Description was changed from

==========
Revert of Mojo C++ bindings: support sync methods - part 2 (patchset #6
id:100001 of https://codereview.chromium.org/1713203002/ )

Reason for revert:
This change is triggering a use-of-uninitialized-value error on the Linux and
Chrome OS MSan bots:

https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...

Original issue's description:
> Mojo C++ bindings: support sync methods - part 2
> 
> This CL introduces the correct re-entrancy behavior: when a sync call is
waiting
> for response, allow incoming sync requests on the same thread to re-enter,
async
> messages are queued until the sync call completes.
> 
> The following will be in future CLs:
> - Support sync calls with associated interfaces.
> 
> BUG=577699
> 
> Committed: https://crrev.com/083f46638041ba7d7620e47a7f9edf06982a9340
> Cr-Commit-Position: refs/heads/master@{#376751}

TBR=jam@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=577699
==========

to

==========
Revert of Mojo C++ bindings: support sync methods - part 2 (patchset #6
id:100001 of https://codereview.chromium.org/1713203002/ )

Reason for revert:
This change is triggering a use-of-uninitialized-value error on the Linux and
Chrome OS MSan bots:

https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...

Original issue's description:
> Mojo C++ bindings: support sync methods - part 2
>
> This CL introduces the correct re-entrancy behavior: when a sync call is
waiting
> for response, allow incoming sync requests on the same thread to re-enter,
async
> messages are queued until the sync call completes.
>
> The following will be in future CLs:
> - Support sync calls with associated interfaces.
>
> BUG=577699
>
> Committed: https://crrev.com/083f46638041ba7d7620e47a7f9edf06982a9340
> Cr-Commit-Position: refs/heads/master@{#376751}

TBR=jam@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=577699

Committed: https://crrev.com/8017c320b4215892c4fdf339e75fea5d5a17ce16
Cr-Commit-Position: refs/heads/master@{#376793}
==========

[commit-bot: I haz the power, 2016-02-22 20:21:17]

Patchset 1 (id:??) landed as
https://crrev.com/8017c320b4215892c4fdf339e75fea5d5a17ce16
Cr-Commit-Position: refs/heads/master@{#376793}