Report a static warning if a for loop condition is non-boolean.

Report a static warning if a for loop condition is non-boolean.

From 17.6.1: "It is a static warning if the static type of c may not be
assigned to bool."

Strong mode catches this case, but it looks like ErrorVerifier just
missed it. Since I'm working on making strong mode lean on ErrorVerifier
for finding sideways casts like this, the discrepancy popped up.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/e9a617548905cd2b5874ffd9940011a5ee41108f

[Bob Nystrom, 2016-02-22 19:31:00]

rnystrom@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-02-22 19:37:52]

LGTM

[Bob Nystrom, 2016-02-22 20:10:55]

Description was changed from

==========
Report a static warning if a for loop condition is non-boolean.

From 17.6.1: "It is a static warning if the static type of c may not be
assigned to bool."

Strong mode catches this case, but it looks like ErrorVerifier just
missed it. Since I'm working on making strong mode lean on ErrorVerifier
for finding sideways casts like this, the discrepancy popped up.
==========

to

==========
Report a static warning if a for loop condition is non-boolean.

From 17.6.1: "It is a static warning if the static type of c may not be
assigned to bool."

Strong mode catches this case, but it looks like ErrorVerifier just
missed it. Since I'm working on making strong mode lean on ErrorVerifier
for finding sideways casts like this, the discrepancy popped up.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e9a617548905cd2b5874ffd9940011a5ee41108f
==========

[Bob Nystrom, 2016-02-22 20:10:57]

Committed patchset #1 (id:1) manually as
e9a617548905cd2b5874ffd9940011a5ee41108f (presubmit successful).