Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: Source/core/animation/DocumentTimeline.cpp

Issue 172003002: Web Animations: Don't mark players as outdated upon currentTime access (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@currentplayers
Patch Set: add test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/animation/Player.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/DocumentTimeline.cpp
diff --git a/Source/core/animation/DocumentTimeline.cpp b/Source/core/animation/DocumentTimeline.cpp
index 681d9ff382aa2d6f257a5958c0294b4e5f8780cf..af825b414bac515c369d2f85056973031ea0d6c6 100644
--- a/Source/core/animation/DocumentTimeline.cpp
+++ b/Source/core/animation/DocumentTimeline.cpp
@@ -93,6 +93,7 @@ void DocumentTimeline::serviceAnimations()
TRACE_EVENT0("webkit", "DocumentTimeline::serviceAnimations");
m_timing->cancelWake();
+ m_hasOutdatedPlayer = false;
double timeToNextEffect = std::numeric_limits<double>::infinity();
Vector<Player*> playersToRemove;
@@ -111,7 +112,7 @@ void DocumentTimeline::serviceAnimations()
else if (timeToNextEffect != std::numeric_limits<double>::infinity())
m_timing->wakeAfter(timeToNextEffect - s_minimumDelay);
- m_hasOutdatedPlayer = false;
+ ASSERT(!m_hasOutdatedPlayer);
}
void DocumentTimeline::setZeroTime(double zeroTime)
« no previous file with comments | « no previous file | Source/core/animation/Player.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698