Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: Source/core/animation/Player.h

Issue 172003002: Web Animations: Don't mark players as outdated upon currentTime access (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@currentplayers
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 bool maybeStartAnimationOnCompositor(); 95 bool maybeStartAnimationOnCompositor();
96 void cancelAnimationOnCompositor(); 96 void cancelAnimationOnCompositor();
97 bool hasActiveAnimationsOnCompositor(); 97 bool hasActiveAnimationsOnCompositor();
98 98
99 private: 99 private:
100 Player(DocumentTimeline&, TimedItem*); 100 Player(DocumentTimeline&, TimedItem*);
101 double sourceEnd() const; 101 double sourceEnd() const;
102 bool limited(double currentTime) const; 102 bool limited(double currentTime) const;
103 double currentTimeWithoutLag() const; 103 double currentTimeWithoutLag() const;
104 double currentTimeWithLag() const; 104 double currentTimeWithLag() const;
105 void updateTimingState(double newCurrentTime); 105 void updateTimingState(double newCurrentTime, bool shouldSetOutdated = true) ;
106 void updateCurrentTimingState(); 106 void updateCurrentTimingState(bool shouldSetOutdated = true);
107 107
108 double m_playbackRate; 108 double m_playbackRate;
109 double m_startTime; 109 double m_startTime;
110 double m_holdTime; 110 double m_holdTime;
111 double m_storedTimeLag; 111 double m_storedTimeLag;
112 112
113 RefPtr<TimedItem> m_content; 113 RefPtr<TimedItem> m_content;
114 // FIXME: We should keep the timeline alive and have this as non-null 114 // FIXME: We should keep the timeline alive and have this as non-null
115 // but this is tricky to do without Oilpan 115 // but this is tricky to do without Oilpan
116 DocumentTimeline* m_timeline; 116 DocumentTimeline* m_timeline;
117 // Reflects all pausing, including via pauseForTesting(). 117 // Reflects all pausing, including via pauseForTesting().
118 bool m_paused; 118 bool m_paused;
119 bool m_held; 119 bool m_held;
120 bool m_isPausedForTesting; 120 bool m_isPausedForTesting;
121 121
122 // This indicates timing information relevant to the player has changed 122 // This indicates timing information relevant to the player has changed
123 bool m_outdated; 123 bool m_outdated;
124 }; 124 };
125 125
126 } // namespace 126 } // namespace
127 127
128 #endif 128 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698