ui/events/blink/input_handler_proxy_unittest.cc - Issue 1720023002: Wheel scrolling with smooth scrolling enabled would cause an extra animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/blink/input_handler_proxy_unittest.cc

Issue 1720023002: Wheel scrolling with smooth scrolling enabled would cause an extra animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing test with adjusted scrollbegin/scroll end approach Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/blink/input_handler_proxy_unittest.cc

diff --git a/ui/events/blink/input_handler_proxy_unittest.cc b/ui/events/blink/input_handler_proxy_unittest.cc

index 08358efb6d0c82fe64b2fcba43f334f3f5264300..6723a319952fa596f730a66cd20f0323523f6253 100644

--- a/ui/events/blink/input_handler_proxy_unittest.cc

+++ b/ui/events/blink/input_handler_proxy_unittest.cc

@@ -639,8 +639,9 @@ TEST_P(InputHandlerProxyTest, DISABLED_GestureScrollByCoarsePixels) {

gesture_.type = WebInputEvent::GestureScrollBegin;

gesture_.data.scrollBegin.deltaHintUnits =

WebGestureEvent::ScrollUnits::Pixels;

- EXPECT_CALL(mock_input_handler_, ScrollAnimated(::testing::_, ::testing::_))

+ EXPECT_CALL(mock_input_handler_, ScrollBegin(::testing::_, ::testing::_))

.WillOnce(testing::Return(kImplThreadScrollState));

+ EXPECT_CALL(mock_input_handler_, ScrollEnd(testing::_));

EXPECT_EQ(expected_disposition_, input_handler_->HandleInputEvent(gesture_));

gesture_.type = WebInputEvent::GestureScrollUpdate;

« no previous file with comments | « ui/events/blink/input_handler_proxy.cc ('k') | no next file » | no next file with comments »