Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 1720003002: [turbofan] fix validator in face of phi optimizations. (Closed)

Created:
4 years, 10 months ago by Mircea Trofin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] fix validator in face of phi optimizations. This fixes an issue encountered in wasm payloads, where we do not (yet) optimize away duplicate phi definitions - phis in the same block with the same operand list; and when move optimizations merge phi- defining moves into the block defining the phi. If all this happens, the register allocation validator back-propagation fails because it can't distinguish the duplicate phis, when traversing backwards. BUG= Committed: https://crrev.com/5ae02268bec405347312b2d912cb6fa5e179704b Cr-Commit-Position: refs/heads/master@{#34207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/compiler/register-allocator-verifier.cc View 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
4 years, 10 months ago (2016-02-22 18:06:33 UTC) #3
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-23 05:30:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720003002/1
4 years, 10 months ago (2016-02-23 07:51:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 07:53:00 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 07:53:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ae02268bec405347312b2d912cb6fa5e179704b
Cr-Commit-Position: refs/heads/master@{#34207}

Powered by Google App Engine
This is Rietveld 408576698