fix misc asserts and checks found by fuzzer

fix misc asserts and checks found by fuzzer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719993002

Committed: https://skia.googlesource.com/skia/+/ca726abe1e4a2522b24e5143c5faf0e594a4802a

[reed1, 2016-02-22 17:01:19]

Description was changed from

==========
fix misc asserts and checks found by fuzzer

BUG=skia:
==========

to

==========
fix misc asserts and checks found by fuzzer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-02-22 17:05:42]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2016-02-22 17:33:24]

ptal

[reed1, 2016-02-22 17:33:30]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 17:33:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719993002/20001

[robertphillips, 2016-02-22 17:40:14]

https://codereview.chromium.org/1719993002/diff/1/samplecode/SampleFilterFuzz...
File samplecode/SampleFilterFuzz.cpp (right):

https://codereview.chromium.org/1719993002/diff/1/samplecode/SampleFilterFuzz...
samplecode/SampleFilterFuzz.cpp:206: static SkPath1DPathEffect::Style
make_path_1d_path_effect_style() {
We don't want to do the kLast_Style thing?

https://codereview.chromium.org/1719993002/diff/1/samplecode/SampleFilterFuzz...
samplecode/SampleFilterFuzz.cpp:531:
SkTypeface::CreateFromName(make_font_name().c_str(), make_typeface_style()));
What's all this then?

[commit-bot: I haz the power, 2016-02-22 17:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 17:57:15]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-02-22 19:57:45]

https://codereview.chromium.org/1719993002/diff/1/samplecode/SampleFilterFuzz...
File samplecode/SampleFilterFuzz.cpp (right):

https://codereview.chromium.org/1719993002/diff/1/samplecode/SampleFilterFuzz...
samplecode/SampleFilterFuzz.cpp:206: static SkPath1DPathEffect::Style
make_path_1d_path_effect_style() {
On 2016/02/22 17:40:14, robertphillips wrote:
> We don't want to do the kLast_Style thing?

Sure, I will add that.

https://codereview.chromium.org/1719993002/diff/1/samplecode/SampleFilterFuzz...
samplecode/SampleFilterFuzz.cpp:531:
SkTypeface::CreateFromName(make_font_name().c_str(), make_typeface_style()));
On 2016/02/22 17:40:14, robertphillips wrote:
> What's all this then?

We could is well defined (at the moment) to NOT support validating serialized
typefaces, so this always asserts.

[reed1, 2016-02-22 19:57:49]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 19:58:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719993002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719993002/40001

[robertphillips, 2016-02-22 20:08:02]

lgtm w/ moving the "#if 0" up a line.

[reed1, 2016-02-22 20:12:48]

The CQ bit was checked by reed@google.com

[reed1, 2016-02-22 20:12:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1719993002/#ps60001
(title: "hide the creation of the typeface as well")

[commit-bot: I haz the power, 2016-02-22 20:12:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719993002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719993002/60001

[commit-bot: I haz the power, 2016-02-22 20:50:28]

Description was changed from

==========
fix misc asserts and checks found by fuzzer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fix misc asserts and checks found by fuzzer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ca726abe1e4a2522b24e5143c5faf0e594a4802a
==========

[commit-bot: I haz the power, 2016-02-22 20:50:28]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/ca726abe1e4a2522b24e5143c5faf0e594a4802a