components/tracing/trace_config_file.cc - Issue 1719983005: base: Stop overloading ReadFileToString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/trace_config_file.cc

Issue 1719983005: base: Stop overloading ReadFileToString() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix errors Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/trace_config_file.cc

diff --git a/components/tracing/trace_config_file.cc b/components/tracing/trace_config_file.cc

index 3e64724b4fa6c274351c3944491be472c9e2e70d..670bcc9c2064d52257d973c4d7a1a9878812d85b 100644

--- a/components/tracing/trace_config_file.cc

+++ b/components/tracing/trace_config_file.cc

@@ -82,9 +82,9 @@ TraceConfigFile::TraceConfigFile()

}

std::string trace_config_file_content;

- if (!base::ReadFileToString(trace_config_file,

- &trace_config_file_content,

- kTraceConfigFileSizeLimit)) {

+ if (!base::ReadFileToStringWithMaxSize(trace_config_file,

+ &trace_config_file_content,

+ kTraceConfigFileSizeLimit)) {

DLOG(WARNING) << "Cannot read the trace config file correctly.";

return;

}