Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1719923002: [coverage] Use optimized builds for coverage data. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, kjellander_chromium
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[coverage] Use optimized builds for coverage data. Local testing suggests that optimized builds add more speed without trading off tool usability. We get the following differences (A: non-optimized build, B: optimized): Sometimes: Lines instrumented in A (covered and uncovered) are not instrumented in B. Rarely: Lines instrumented and covered in A are instrumented, but not covered in B. The latter might simply be caused by timing differences in the two builds. BUG=chromium:568949 LOG=n NOTRY=true Committed: https://crrev.com/ea0530af5766c1179cb14b0c00c1b81b2050fb77 Cr-Commit-Position: refs/heads/master@{#34193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/standalone.gypi View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL
4 years, 10 months ago (2016-02-22 14:20:05 UTC) #3
tandrii(chromium)
lgtm
4 years, 10 months ago (2016-02-22 14:29:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719923002/1
4 years, 10 months ago (2016-02-22 14:37:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 14:38:31 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 14:39:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea0530af5766c1179cb14b0c00c1b81b2050fb77
Cr-Commit-Position: refs/heads/master@{#34193}

Powered by Google App Engine
This is Rietveld 408576698