Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1719913002: fix misc asserts and checks found by fuzzer (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -41 lines) Patch
M include/core/SkPathEffect.h View 2 chunks +14 lines, -2 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 2 chunks +1 line, -5 lines 0 comments Download
M include/effects/SkDashPathEffect.h View 3 chunks +3 lines, -4 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 2 chunks +32 lines, -28 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719913002/1
4 years, 10 months ago (2016-02-22 14:06:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/653db51b440491b0fb1908bf5a43dcc89c90044d
4 years, 10 months ago (2016-02-22 14:34:50 UTC) #5
ethannicholas
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1721743002/ by ethannicholas@google.com. ...
4 years, 10 months ago (2016-02-22 15:42:01 UTC) #6
robertphillips
4 years, 10 months ago (2016-02-22 16:03:07 UTC) #7
Message was sent while issue was closed.
The failing cc unit test is using AlphaThresholdFilters so I think the unit
square check wasn't optional.

Powered by Google App Engine
This is Rietveld 408576698