Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: src/profiler/heap-snapshot-generator.cc

Issue 1719903002: Fix AllocationSite body descriptor to include all pointer slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/snapshot/serialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/profiler/heap-snapshot-generator.h" 5 #include "src/profiler/heap-snapshot-generator.h"
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/conversions.h" 8 #include "src/conversions.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/objects-body-descriptors.h" 10 #include "src/objects-body-descriptors.h"
(...skipping 1514 matching lines...) Expand 10 before | Expand all | Expand 10 after
1525 SetInternalReference(site, entry, "transition_info", site->transition_info(), 1525 SetInternalReference(site, entry, "transition_info", site->transition_info(),
1526 AllocationSite::kTransitionInfoOffset); 1526 AllocationSite::kTransitionInfoOffset);
1527 SetInternalReference(site, entry, "nested_site", site->nested_site(), 1527 SetInternalReference(site, entry, "nested_site", site->nested_site(),
1528 AllocationSite::kNestedSiteOffset); 1528 AllocationSite::kNestedSiteOffset);
1529 MarkAsWeakContainer(site->dependent_code()); 1529 MarkAsWeakContainer(site->dependent_code());
1530 SetInternalReference(site, entry, "dependent_code", site->dependent_code(), 1530 SetInternalReference(site, entry, "dependent_code", site->dependent_code(),
1531 AllocationSite::kDependentCodeOffset); 1531 AllocationSite::kDependentCodeOffset);
1532 // Do not visit weak_next as it is not visited by the StaticVisitor, 1532 // Do not visit weak_next as it is not visited by the StaticVisitor,
1533 // and we're not very interested in weak_next field here. 1533 // and we're not very interested in weak_next field here.
1534 STATIC_ASSERT(AllocationSite::kWeakNextOffset >= 1534 STATIC_ASSERT(AllocationSite::kWeakNextOffset >=
1535 AllocationSite::BodyDescriptor::kEndOffset); 1535 AllocationSite::kPointerFieldsEndOffset);
1536 } 1536 }
1537 1537
1538 1538
1539 class JSArrayBufferDataEntryAllocator : public HeapEntriesAllocator { 1539 class JSArrayBufferDataEntryAllocator : public HeapEntriesAllocator {
1540 public: 1540 public:
1541 JSArrayBufferDataEntryAllocator(size_t size, V8HeapExplorer* explorer) 1541 JSArrayBufferDataEntryAllocator(size_t size, V8HeapExplorer* explorer)
1542 : size_(size) 1542 : size_(size)
1543 , explorer_(explorer) { 1543 , explorer_(explorer) {
1544 } 1544 }
1545 virtual HeapEntry* AllocateEntry(HeapThing ptr) { 1545 virtual HeapEntry* AllocateEntry(HeapThing ptr) {
(...skipping 1608 matching lines...) Expand 10 before | Expand all | Expand 10 after
3154 for (int i = 1; i < sorted_strings.length(); ++i) { 3154 for (int i = 1; i < sorted_strings.length(); ++i) {
3155 writer_->AddCharacter(','); 3155 writer_->AddCharacter(',');
3156 SerializeString(sorted_strings[i]); 3156 SerializeString(sorted_strings[i]);
3157 if (writer_->aborted()) return; 3157 if (writer_->aborted()) return;
3158 } 3158 }
3159 } 3159 }
3160 3160
3161 3161
3162 } // namespace internal 3162 } // namespace internal
3163 } // namespace v8 3163 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/snapshot/serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698