Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1719903002: Fix AllocationSite body descriptor to include all pointer slots. (Closed)

Created:
4 years, 10 months ago by ulan
Modified:
4 years, 10 months ago
Reviewers:
mvstanton, Yang
CC:
v8-reviews_googlegroups.com, mvstanton
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix AllocationSite body descriptor to include all pointer slots. Currently AllocationSite skips the weak_next pointer in IterateBody and IsValidSlot. This is not correct because the weak_next is a valid slot in AllocationSite. BUG= Committed: https://crrev.com/72f884a19fa4434bba6fc0e013ec4ea0a2366893 Cr-Commit-Position: refs/heads/master@{#34192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M src/objects.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/snapshot/serialize.cc View 3 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ulan
Yang, ptal. Michael, fyi.
4 years, 10 months ago (2016-02-22 13:15:07 UTC) #2
Yang
On 2016/02/22 13:15:07, ulan wrote: > Yang, ptal. > > Michael, fyi. lgtm.
4 years, 10 months ago (2016-02-22 13:18:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719903002/1
4 years, 10 months ago (2016-02-22 13:22:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 13:47:46 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72f884a19fa4434bba6fc0e013ec4ea0a2366893 Cr-Commit-Position: refs/heads/master@{#34192}
4 years, 10 months ago (2016-02-22 13:48:33 UTC) #8
mvstanton
4 years, 10 months ago (2016-02-22 17:16:32 UTC) #10
Message was sent while issue was closed.
thx for the heads up! lgtm.

Powered by Google App Engine
This is Rietveld 408576698