Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: components/safe_browsing_db/BUILD.gn

Issue 1719883003: Ignore: v4_update_protocol_manager: Basic implementation with TODOs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v4_01_prot_mgr
Patch Set: Basic implementation of the update protocol manager with histograms and TODOs. No tests yet. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/BUILD.gn
diff --git a/components/safe_browsing_db/BUILD.gn b/components/safe_browsing_db/BUILD.gn
index 9aa781c68cbb47170200698ac15f93f4477d2ced..13ab9ef4d6c969acd89851b49baf3df30c2efc32 100644
--- a/components/safe_browsing_db/BUILD.gn
+++ b/components/safe_browsing_db/BUILD.gn
@@ -121,6 +121,17 @@ source_set("safe_browsing_api_handler_util") {
]
}
+source_set("test_database_manager") {
+ sources = [
+ "test_database_manager.cc",
+ "test_database_manager.h",
+ ]
+ deps = [
+ ":database_manager",
+ "//base:base",
+ ]
+}
+
source_set("util") {
sources = [
"util.cc",
@@ -128,8 +139,10 @@ source_set("util") {
]
deps = [
"//base",
+ "//base:base",
"//crypto",
"//net",
+ "//url:url",
]
if (is_win) {
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
@@ -137,17 +150,6 @@ source_set("util") {
}
}
-source_set("test_database_manager") {
- sources = [
- "test_database_manager.cc",
- "test_database_manager.h",
- ]
- deps = [
- ":database_manager",
- "//base:base",
- ]
-}
-
source_set("v4_get_hash_protocol_manager") {
sources = [
"v4_get_hash_protocol_manager.cc",
@@ -170,7 +172,26 @@ source_set("v4_protocol_manager_util") {
"v4_protocol_manager_util.cc",
"v4_protocol_manager_util.h",
]
+ public_deps = [
+ ":proto",
+ ]
+ deps = [
+ ":proto",
+ "//base",
+ "//net",
+ "//url:url",
+ ]
+}
+
+source_set("v4_update_protocol_manager") {
+ sources = [
+ "v4_update_protocol_manager.cc",
+ "v4_update_protocol_manager.h",
+ ]
deps = [
+ ":proto",
+ ":util",
+ ":v4_protocol_manager_util",
"//base",
"//net",
"//url:url",
@@ -191,6 +212,7 @@ source_set("unit_tests") {
":util",
":v4_get_hash_protocol_manager",
":v4_protocol_manager_util",
+ ":v4_update_protocol_manager",
"//base",
"//net",
"//net:test_support",

Powered by Google App Engine
This is Rietveld 408576698