Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1719883003: Ignore: v4_update_protocol_manager: Basic implementation with TODOs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v4_01_prot_mgr
Patch Set: Basic implementation of the update protocol manager with histograms and TODOs. No tests yet. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 53d202e20c5942eb3eae023afd8f77d29819e77c..7588010b721998082fa4f1764b9653e2738c2b51 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -41531,7 +41531,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="SafeBrowsing.GetV4HashResult"
- enum="SafeBrowsingGetV4HashResult">
+ enum="SafeBrowsingGetV4OperationResult">
<owner>kcarattini@chromium.org</owner>
<summary>
Track return status from V4 GetHash attempts. The buckets of this histogram
@@ -41556,6 +41556,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SafeBrowsing.ParseV4UpdateResult"
+ enum="SafeBrowsingParseV4UpdateResult">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Track the parsing results of a status 200 GetV4Update request.
+ </summary>
+</histogram>
+
<histogram name="SafeBrowsing.Pref.Extended" enum="BooleanEnabled">
<owner>nparker@chromium.org</owner>
<summary>
@@ -41621,6 +41629,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SafeBrowsing.V4UpdateResult"
+ enum="SafeBrowsingGetV4OperationResult">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Track return status from V4 update attempts. The buckets of this histogram
+ overlap, so the counts cannot be used as percentages.
+ </summary>
+</histogram>
+
<histogram name="SB.BloomFilter" units="ms">
<obsolete>
Has not been generated for years (7/8/14).
@@ -77859,7 +77876,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="1" label="Kill (He's dead, Jim!)"/>
</enum>
-<enum name="SafeBrowsingGetV4HashResult" type="int">
+<enum name="SafeBrowsingGetV4OperationResult" type="int">
<int value="0" label="STATUS_200"/>
<int value="1" label="PARSE_ERROR (subset of STATUS_200)"/>
<int value="2" label="NETWORK_ERROR"/>
@@ -77877,6 +77894,10 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="5" label="INCONSISTENT_THREAT_TYPE_ERROR"/>
</enum>
+<enum name="SafeBrowsingParseV4UpdateResult" type="int">
+ <int value="0" label="PARSE_FROM_STRING_ERROR"/>
+</enum>
+
<enum name="SavePasswordPromptResponseType" type="int">
<int value="0" label="NO_RESPONSE"/>
<int value="1" label="REMEMBER_PASSWORD"/>

Powered by Google App Engine
This is Rietveld 408576698