Ignore: v4_update_protocol_manager: Basic implementation with TODOs

components/safe_browsing_db/v4_update_protocol_manager.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_SAFE_BROWSING_DB_V4_UPDATE_PROTOCOL_MANAGER_H_
+#define COMPONENTS_SAFE_BROWSING_DB_V4_UPDATE_PROTOCOL_MANAGER_H_
+
+// A class that implements Chrome's interface with the SafeBrowsing V4 protocol.

[Nathan Parker, 2016/02/23 18:47:06]

"...V4 update protocol"

[vakh (use Gerrit instead), 2016/02/23 23:58:20]

Done.

+//
+// The V4UpdateProtocolManager handles formatting and making requests of, and
+// handling responses from, Google's SafeBrowsing servers. The purpose of this
+// class is to get full hash matches from the SB server for the given set of

[Nathan Parker, 2016/02/23 18:47:06]

Is this right?  (the full hash match line)

[vakh (use Gerrit instead), 2016/02/23 23:58:20]

Done.

+// hash prefixes.
+
+#include <string>
+#include <vector>
+
+#include "base/gtest_prod_util.h"
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/threading/non_thread_safe.h"
+#include "base/time/time.h"
+#include "base/timer/timer.h"
+#include "components/safe_browsing_db/safebrowsing.pb.h"
+#include "components/safe_browsing_db/util.h"
+#include "components/safe_browsing_db/v4_protocol_manager_util.h"
+#include "net/url_request/url_fetcher_delegate.h"
+#include "url/gurl.h"
+
+namespace net {
+class URLFetcher;
+class URLRequestContextGetter;
+}  // namespace net
+
+namespace safe_browsing {
+
+class V4UpdateProtocolManagerFactory;
+
+class V4UpdateProtocolManager : public net::URLFetcherDelegate,
+                                 public base::NonThreadSafe {
+ public:
+  typedef FetchThreatListUpdatesRequest::ListUpdateRequest ListUpdateRequest;
+  typedef FetchThreatListUpdatesResponse::ListUpdateResponse ListUpdateResponse;
+
+  // UpdateCallback is invoked when GetUpdateWithClientInfo completes.
+  // Parameters:
+  //   - The vector of update response protobufs received from the server for
+  //     each list type.
+  typedef base::Callback<void(const std::vector<ListUpdateResponse>&)>
+      UpdateCallback;
+
+  ~V4UpdateProtocolManager() override;
+
+  // Makes the passed |factory| the factory used to instantiate
+  // a V4UpdateProtocolManager. Useful for tests.
+  static void RegisterFactory(V4UpdateProtocolManagerFactory* factory) {
+    factory_ = factory;
+  }
+
+  // Create an instance of the safe browsing v4 protocol manager.
+  static V4UpdateProtocolManager* Create(
+      net::URLRequestContextGetter* request_context_getter,
+      const V4ProtocolConfig& config);
+
+  // net::URLFetcherDelegate interface.
+  void OnURLFetchComplete(const net::URLFetcher* source) override;
+
+  // Retrieve the hash prefix update, and invoke the callback argument when the
+  // results are retrieved. The callback may be invoked synchronously.
+  virtual void GetUpdates(
+      const base::hash_set<UpdateListIdentifier>& lists_to_update,
+      UpdateCallback callback);
+
+  // Record an update operation result.
+  static void RecordUpdateResult(OperationResultType result_type);
+
+ protected:
+  // Constructs a V4UpdateProtocolManager that issues
+  // network requests using |request_context_getter|.
+  V4UpdateProtocolManager(
+      net::URLRequestContextGetter* request_context_getter,
+      const V4ProtocolConfig& config);
+
+ private:
+  friend class V4UpdateProtocolManagerFactoryImpl;
+
+  GURL GetUpdateUrl(const std::string& request_base64) const;
+
+  // Fills a FetchThreatListUpdatesRequest protocol buffer for a request.
+  // Returns the serialized and base 64 encoded request as a string.
+  std::string GetUpdateRequest(
+      const base::hash_set<UpdateListIdentifier>& lists_to_update);
+
+  // Parses the base64 encoded response received from the server as a
+  // FetchThreatListUpdatesResponse protobuf and returns each of the
+  // ListUpdateResponse protobufs contained in it as a vector.
+  // Returns true if parsing is successful, false otherwise.
+  bool ParseUpdateResponse(
+      const std::string& data_base64,
+      std::vector<ListUpdateResponse>* list_update_responses);
+
+  // Resets the update error counter and multiplier.
+  void ResetUpdateErrors();
+
+  // Updates internal update and backoff state for each update response error,
+  // assuming that the current time is |now|.
+  void HandleUpdateError(const base::Time& now);
+
+ private:
+  // Map of update requests to parameters which created it.
+  typedef base::hash_map<const net::URLFetcher*, UpdateCallback> UpdateRequests;
+
+  // The factory that controls the creation of V4UpdateProtocolManager.
+  // This is used by tests.
+  static V4UpdateProtocolManagerFactory* factory_;
+
+  // Current active request (in case we need to cancel) for updates or chunks
+  // from the SafeBrowsing service.
+  scoped_ptr<net::URLFetcher> request_;

[Nathan Parker, 2016/02/23 18:47:06]

If there's only one, then we don't need a map above, ya? We probably shouldn't
have more than one at once.

[vakh (use Gerrit instead), 2016/02/23 23:58:20]

Done.

+
+  // The number of HTTP response errors since the the last successful HTTP
+  // response, used for request backoff timing.
+  size_t update_error_count_;
+
+  // Multiplier for the backoff error after the second.
+  size_t update_back_off_mult_;
+
+  UpdateRequests update_requests_;

[Nathan Parker, 2016/02/23 18:47:06]

Is this this the UpdateRequests for the outstanding request_?

[vakh (use Gerrit instead), 2016/02/23 23:58:20]

Yes. Changed.

+
+  // For v4, the next update time is set to the backoff time is the last

[Nathan Parker, 2016/02/23 18:47:06]

rm "For v4"

[vakh (use Gerrit instead), 2016/02/23 23:58:20]

Done.

+  // response was an error, or the minimum wait time if the last response was
+  // successful.
+  base::Time next_update_time_;
+
+  // The config of the client making Pver4 requests.
+  const V4ProtocolConfig config_;
+
+  // The context we use to issue network requests.
+  scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
+
+  // ID for URLFetchers for testing.
+  int url_fetcher_id_;
+
+  base::hash_map<UpdateListIdentifier, const std::string&> list_states_;
+
+  DISALLOW_COPY_AND_ASSIGN(V4UpdateProtocolManager);
+};
+
+// Interface of a factory to create V4UpdateProtocolManager.  Useful for tests.
+class V4UpdateProtocolManagerFactory {
+ public:
+  V4UpdateProtocolManagerFactory() {}
+  virtual ~V4UpdateProtocolManagerFactory() {}
+  virtual V4UpdateProtocolManager* CreateProtocolManager(
+      net::URLRequestContextGetter* request_context_getter,
+      const V4ProtocolConfig& config) = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(V4UpdateProtocolManagerFactory);
+};
+
+}  // namespace safe_browsing
+
+#endif  // COMPONENTS_SAFE_BROWSING_DB_V4_UPDATE_PROTOCOL_MANAGER_H_