Ignore: v4_update_protocol_manager: Basic implementation with TODOs

components/safe_browsing_db/v4_get_hash_protocol_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_
 #define COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_
 
 // A class that implements Chrome's interface with the SafeBrowsing V4 protocol.
 //
 // The V4GetHashProtocolManager handles formatting and making requests of, and
@@ skipping 30 matching lines @@
  public:
   // FullHashCallback is invoked when GetFullHashes completes.
   // Parameters:
   //   - The vector of full hash results. If empty, indicates that there
   //     were no matches, and that the resource is safe.
   //   - The negative cache duration of the result.
   typedef base::Callback<void(const std::vector<SBFullHashResult>&,
                               const base::TimeDelta&)>
       FullHashCallback;
 
+  typedef V4ProtocolManagerUtil::OperationResultType OperationResultType;
+
   ~V4GetHashProtocolManager() override;
 
   // Makes the passed |factory| the factory used to instantiate
   // a V4GetHashProtocolManager. Useful for tests.
   static void RegisterFactory(V4GetHashProtocolManagerFactory* factory) {
     factory_ = factory;
   }
 
   // Create an instance of the safe browsing v4 protocol manager.
   static V4GetHashProtocolManager* Create(
@@ skipping 10 matching lines @@
                              const std::vector<PlatformType>& platforms,
                              ThreatType threat_type,
                              FullHashCallback callback);
 
   // Retrieve the full hash and API metadata for a set of prefixes, and invoke
   // the callback argument when the results are retrieved. The callback may be
   // invoked synchronously.
   virtual void GetFullHashesWithApis(const std::vector<SBPrefix>& prefixes,
                                      FullHashCallback callback);
 
-  // Enumerate failures for histogramming purposes.  DO NOT CHANGE THE
-  // ORDERING OF THESE VALUES.
-  enum ResultType {
-    // 200 response code means that the server recognized the hash
-    // prefix.
-    GET_HASH_STATUS_200 = 0,
-
-    // Subset of successful responses where the response body wasn't parsable.
-    GET_HASH_PARSE_ERROR = 1,
-
-    // Gethash request failed (network error).
-    GET_HASH_NETWORK_ERROR = 2,
-
-    // Gethash request returned HTTP result code other than 200.
-    GET_HASH_HTTP_ERROR = 3,
-
-    // Gethash attempted during error backoff, no request sent.
-    GET_HASH_BACKOFF_ERROR = 4,
-
-    // Gethash attempted before min wait duration elapsed, no request sent.
-    GET_HASH_MIN_WAIT_DURATION_ERROR = 5,
-
-    // Memory space for histograms is determined by the max.  ALWAYS
-    // ADD NEW VALUES BEFORE THIS ONE.
-    GET_HASH_RESULT_MAX = 6
-  };
-
   // Record a GetHash result.
-  static void RecordGetHashResult(ResultType result_type);
+  static void RecordGetHashResult(OperationResultType result_type);
 
  protected:
   // Constructs a V4GetHashProtocolManager that issues
   // network requests using |request_context_getter|.
   V4GetHashProtocolManager(
       net::URLRequestContextGetter* request_context_getter,
       const V4ProtocolConfig& config);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingV4GetHashProtocolManagerTest,
@@ skipping 88 matching lines @@
       net::URLRequestContextGetter* request_context_getter,
       const V4ProtocolConfig& config) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(V4GetHashProtocolManagerFactory);
 };
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_