Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/module.py

Issue 1719873003: Mojom runtime type info: New implementation for Go. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Rebasing Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/pylib/mojom/generate/module.py
diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/module.py b/mojo/public/tools/bindings/pylib/mojom/generate/module.py
index b3e8e754d51ed9e37c7f46aea791b795cec029df..95e4e3ce5ed8c5ad4893002e57b4ee60e14f4462 100644
--- a/mojo/public/tools/bindings/pylib/mojom/generate/module.py
+++ b/mojo/public/tools/bindings/pylib/mojom/generate/module.py
@@ -215,6 +215,7 @@ class Struct(ReferenceKind):
ReferenceKind.AddSharedProperty('attributes')
ReferenceKind.AddSharedProperty('constants')
ReferenceKind.AddSharedProperty('enums')
+ ReferenceKind.AddSharedProperty('type_key')
def __init__(self, name=None, module=None, attributes=None):
if name is not None:
@@ -242,6 +243,7 @@ class Union(ReferenceKind):
ReferenceKind.AddSharedProperty('imported_from')
ReferenceKind.AddSharedProperty('fields')
ReferenceKind.AddSharedProperty('attributes')
+ ReferenceKind.AddSharedProperty('type_key')
def __init__(self, name=None, module=None, attributes=None):
if name is not None:
@@ -374,6 +376,7 @@ class Interface(ReferenceKind):
ReferenceKind.AddSharedProperty('attributes')
ReferenceKind.AddSharedProperty('constants')
ReferenceKind.AddSharedProperty('enums')
+ ReferenceKind.AddSharedProperty('type_key')
def __init__(self, name=None, module=None, attributes=None):
if name is not None:
@@ -475,6 +478,8 @@ def GetPackageName(kind):
"""Get the package name from the given kind's module."""
return kind.module.name.split('.')[0]
+# TODO(rudominer) Remove this once the switch to the new runtime type
+# discovery mechanism is complete.
def GetMojomTypeIdentifier(kind):
"""Get the mojom type's unique identifier from the kind's package and name."""
# Note: InterfaceRequest's should use the Interface inside them.
@@ -490,6 +495,8 @@ def GetMojomTypeIdentifier(kind):
# Returns a string of the form package.path.TypeName - the full identifier
# for an element.
+# TODO(rudominer) Remove this once the switch to the new runtime type
+# discovery mechanism is complete.
def GetMojomTypeFullIdentifier(kind, exported=True):
"""Get the Full Identifier for a Mojom Type. Format: package.path.TypeName"""
return '%s.%s' % (kind.module.namespace, GetMojomTypeName(kind))

Powered by Google App Engine
This is Rietveld 408576698