Don't use PathService for the location of nacl_helper and nacl_helper_bootstrap

chrome/common/nacl_paths.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_NACL_PATHS_H_
+#define CHROME_COMMON_NACL_PATHS_H_
+
+#include "build/build_config.h"
+
+// This file declares path keys for the chrome module.  These can be used with
+// the PathService to access various special directories and files.
+
+namespace nacl {
+
+enum {
+  PATH_START = 9000,

[Mark Seaborn, 2013/06/21 13:53:26]

Where does 9000 come from?  What stops this from clashing?

+
+#if defined(OS_POSIX) && !defined(OS_MACOSX)

[Mark Seaborn, 2013/06/21 13:53:26]

Better to use OS_LINUX here too

+  FILE_NACL_HELPER = PATH_START, // Full path to Linux nacl_helper executable.
+  FILE_NACL_HELPER_BOOTSTRAP,    // ... and nacl_helper_bootstrap executable.
+#endif
+
+  PATH_END
+};
+
+// Call once to register the provider for the path keys defined above.
+void RegisterPathProvider();
+
+}  // namespace nacl
+
+#endif  // CHROME_COMMON_NACL_PATHS_H_