Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 17198012: MIPS: Let NaN flow as double into HBranch + some minor improvements (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 985 matching lines...) Expand 10 before | Expand all | Expand 10 after
996 HValue* value = instr->value(); 996 HValue* value = instr->value();
997 if (value->EmitAtUses()) { 997 if (value->EmitAtUses()) {
998 HBasicBlock* successor = HConstant::cast(value)->BooleanValue() 998 HBasicBlock* successor = HConstant::cast(value)->BooleanValue()
999 ? instr->FirstSuccessor() 999 ? instr->FirstSuccessor()
1000 : instr->SecondSuccessor(); 1000 : instr->SecondSuccessor();
1001 return new(zone()) LGoto(successor->block_id()); 1001 return new(zone()) LGoto(successor->block_id());
1002 } 1002 }
1003 1003
1004 LBranch* result = new(zone()) LBranch(UseRegister(value)); 1004 LBranch* result = new(zone()) LBranch(UseRegister(value));
1005 // Tagged values that are not known smis or booleans require a 1005 // Tagged values that are not known smis or booleans require a
1006 // deoptimization environment. 1006 // deoptimization environment. If the instruction is generic no
1007 // environment is needed since all cases are handled.
1007 Representation rep = value->representation(); 1008 Representation rep = value->representation();
1008 HType type = value->type(); 1009 HType type = value->type();
1009 if (rep.IsTagged() && !type.IsSmi() && !type.IsBoolean()) { 1010 ToBooleanStub::Types expected = instr->expected_input_types();
1011 if (rep.IsTagged() && !type.IsSmi() && !type.IsBoolean() &&
1012 !expected.IsGeneric()) {
1010 return AssignEnvironment(result); 1013 return AssignEnvironment(result);
1011 } 1014 }
1012 return result; 1015 return result;
1013 } 1016 }
1014 1017
1015 1018
1016 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) { 1019 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) {
1017 ASSERT(instr->value()->representation().IsTagged()); 1020 ASSERT(instr->value()->representation().IsTagged());
1018 LOperand* value = UseRegisterAtStart(instr->value()); 1021 LOperand* value = UseRegisterAtStart(instr->value());
1019 LOperand* temp = TempRegister(); 1022 LOperand* temp = TempRegister();
(...skipping 1557 matching lines...) Expand 10 before | Expand all | Expand 10 after
2577 2580
2578 2581
2579 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2582 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2580 LOperand* object = UseRegister(instr->object()); 2583 LOperand* object = UseRegister(instr->object());
2581 LOperand* index = UseRegister(instr->index()); 2584 LOperand* index = UseRegister(instr->index());
2582 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2585 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2583 } 2586 }
2584 2587
2585 2588
2586 } } // namespace v8::internal 2589 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698