Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171973002: Add experiment groups for <link rel=prefetch> experiment. (Closed)

Created:
6 years, 10 months ago by Shuhei Takahashi
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, hiroshimizuno, hurst_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Add experiment groups for <link rel=prefetch> experiment. BUG=327419 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252758

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebased on top of r252330 #

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/common/metrics/variations/variation_ids.h View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Shuhei Takahashi
stevet, asvitkine: could you review this change please?
6 years, 10 months ago (2014-02-19 04:58:43 UTC) #1
Shuhei Takahashi
+hurst
6 years, 10 months ago (2014-02-19 11:09:10 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 10 months ago (2014-02-19 13:44:09 UTC) #3
Alexei Svitkine (slow)
Oops, not lgtm. There's another pending changing to take the next set of ids. Can ...
6 years, 10 months ago (2014-02-19 13:45:54 UTC) #4
Shuhei Takahashi
On 2014/02/19 13:45:54, Alexei Svitkine wrote: > Oops, not lgtm. > > There's another pending ...
6 years, 10 months ago (2014-02-20 02:54:02 UTC) #5
justincohen
The CQ bit was checked by justincohen@chromium.org
6 years, 10 months ago (2014-02-20 03:23:44 UTC) #6
Shuhei Takahashi
The CQ bit was unchecked by nya@chromium.org
6 years, 10 months ago (2014-02-20 09:05:07 UTC) #7
Shuhei Takahashi
On 2014/02/20 09:05:07, Shuhei Takahashi wrote: > The CQ bit was unchecked by mailto:nya@chromium.org Rebased ...
6 years, 10 months ago (2014-02-21 03:35:40 UTC) #8
Shuhei Takahashi
It seems like stevet/asvitkine are OOO today, so I added isherman and mpearson as reviewers. ...
6 years, 10 months ago (2014-02-21 23:46:53 UTC) #9
Mark P
lgtm please make sure you're synced to top of three and then make sure your ...
6 years, 10 months ago (2014-02-21 23:52:21 UTC) #10
Shuhei Takahashi
The CQ bit was checked by nya@chromium.org
6 years, 10 months ago (2014-02-21 23:57:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nya@chromium.org/171973002/210001
6 years, 10 months ago (2014-02-22 00:01:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nya@chromium.org/171973002/210001
6 years, 10 months ago (2014-02-22 01:30:31 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 07:49:09 UTC) #14
Message was sent while issue was closed. 
Change committed as 252758

Powered by Google App Engine
This is Rietveld 408576698