Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1719543002: Tidy CFX_FixedBufGrow. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tidy CFX_FixedBufGrow. Stop short of removing it since it looks like it may be used in some very hot paths. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/33364e2d6f9549d7964611097c663264548a5d68

Patch Set 1 #

Total comments: 2

Patch Set 2 : explicit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M core/include/fxcrt/fx_basic.h View 1 1 chunk +9 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, next one. Thanks.
4 years, 10 months ago (2016-02-19 23:28:50 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1719543002/diff/1/core/include/fxcrt/fx_basic.h File core/include/fxcrt/fx_basic.h (right): https://codereview.chromium.org/1719543002/diff/1/core/include/fxcrt/fx_basic.h#newcode583 core/include/fxcrt/fx_basic.h:583: CFX_FixedBufGrow(int data_size) { explicit
4 years, 10 months ago (2016-02-19 23:57:25 UTC) #4
Tom Sepez
Committed patchset #2 (id:20001) manually as 33364e2d6f9549d7964611097c663264548a5d68 (presubmit successful).
4 years, 10 months ago (2016-02-20 00:26:57 UTC) #6
Tom Sepez
4 years, 10 months ago (2016-02-20 00:27:48 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1719543002/diff/1/core/include/fxcrt/fx_basic.h
File core/include/fxcrt/fx_basic.h (right):

https://codereview.chromium.org/1719543002/diff/1/core/include/fxcrt/fx_basic...
core/include/fxcrt/fx_basic.h:583: CFX_FixedBufGrow(int data_size) {
On 2016/02/19 23:57:25, Lei Zhang wrote:
> explicit

Done.

Powered by Google App Engine
This is Rietveld 408576698