third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h - Issue 1719533002: Modify YUV codecs to match Skia's API change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

Issue 1719533002: Modify YUV codecs to match Skia's API change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ASSERT in base class YUV implementations, Use ArrayBuffer Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/images/resources/cropped_mandrill.jpg ('k') | third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp » ('j') | third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

diff --git a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

index 64e08953cd90d2b09aaa2e1b7a71a1eee451c9fe..9c9da7efaa730c284aaec3003aaa81fba74cf71a 100644

--- a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

+++ b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

@@ -59,7 +59,9 @@ protected:

bool onGetPixels(const SkImageInfo&, void* pixels, size_t rowBytes, SkPMColor table[], int* tableCount) override;

- bool onGetYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3], SkYUVColorSpace*) override;

+ bool onQueryYUV8(SkYUVSizeInfo*, SkYUVColorSpace*) const override;

+ bool onGetYUV8Planes(const SkYUVSizeInfo&, void*[3]) override;

Noel Gordon 2016/03/01 02:27:49 void*[3] -> void* planes[3] here?

msarett 2016/03/01 18:00:38 sgtm

private:

RefPtr<ImageFrameGenerator> m_frameGenerator;