Issue 1719493002: Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf."

Issue 1719493002: Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf." (Closed)

Created:
4 years, 10 months ago by Tom Sepez

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf." This reverts commit 78353d5dbc0b0c9b2d6946005439a51efa7d108c. Reason for revert Failed tests. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ffc26c26f0ab004fbdb05195e1686d7f33983b06

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -145 lines)			Patch
M	core/include/fxcrt/fx_basic.h	View	3 chunks	+69 lines, -41 lines	0 comments	Download
M	core/include/fxcrt/fx_safe_types.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_fax.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	core/src/fxcrt/fx_basic_buffer.cpp	View	1 chunk	+98 lines, -76 lines	0 comments	Download
M	fpdfsdk/src/fsdk_baseform.cpp	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	xfa/src/fxfa/src/fm2js/xfa_fm2jscontext.cpp	View	6 chunks	+8 lines, -17 lines	0 comments	Download
M	xfa/src/fxfa/src/fm2js/xfa_simpleexpression.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as ffc26c26f0ab004fbdb05195e1686d7f33983b06 (presubmit successful).

4 years, 10 months ago (2016-02-19 22:28:16 UTC) #2

Message was sent while issue was closed.

doh!