Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1719453003: [GN] Add -Wno-unused-result on Linux (Closed)

Created:
4 years, 10 months ago by jungshik at Google
Modified:
4 years, 10 months ago
Reviewers:
slan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@m49
Target Ref:
refs/heads/chromium/m49
Visibility:
Public.

Description

[GN] Add -Wno-unused-result on Linux fread is used in putil.cpp without examining the return value. Suppress this warning for ICU code only. This is done for chromium/m49 branch (that can be used for head, too) because origin/master is already ICU 56.1 that does not need this warning to be suppressed. Original Patch by slan@ : https://codereview.chromium.org/1704763002/ BUG=587965 R=slan@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/e466f6ac8f60bb9697af4a91c6911c6fc4aec95f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jungshik at Google
I copied your CL to chromium/m49
4 years, 10 months ago (2016-02-19 20:01:09 UTC) #2
slan
lgtm
4 years, 10 months ago (2016-02-19 20:02:18 UTC) #3
jungshik at Google
4 years, 10 months ago (2016-02-19 20:04:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e466f6ac8f60bb9697af4a91c6911c6fc4aec95f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698