Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1719443002: chrome_watcher_main.cc: Fix -Wsign-compare error (Closed)

Created:
4 years, 10 months ago by hans
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome_watcher_main.cc: Fix -Wsign-compare error ..\..\chrome\chrome_watcher\chrome_watcher_main.cc(269,23): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] if (suspend_count != -1) { ~~~~~~~~~~~~~ ^ ~~ BUG=82385 TBR=siggi Committed: https://crrev.com/a83fb3a4c55025a39a0ec95ba10504affdc33e95 Cr-Commit-Position: refs/heads/master@{#376500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/chrome_watcher/chrome_watcher_main.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719443002/1
4 years, 10 months ago (2016-02-19 18:05:27 UTC) #4
Sigurður Ásgeirsson
lgtm - thanks!
4 years, 10 months ago (2016-02-19 18:07:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 18:48:27 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 18:49:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a83fb3a4c55025a39a0ec95ba10504affdc33e95
Cr-Commit-Position: refs/heads/master@{#376500}

Powered by Google App Engine
This is Rietveld 408576698