Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 1719353002: Define protected to apply to fields (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
pquitslund, Hixie
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : additional changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M pkg/meta/lib/meta.dart View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-23 01:54:20 UTC) #2
pquitslund
LGTM!
4 years, 10 months ago (2016-02-23 05:12:12 UTC) #3
Brian Wilkerson
I realized that I needed to re-word the second paragraph as well. While I was ...
4 years, 10 months ago (2016-02-23 15:10:43 UTC) #4
pquitslund
LGTM!
4 years, 10 months ago (2016-02-23 16:37:53 UTC) #5
Brian Wilkerson
4 years, 10 months ago (2016-02-24 21:55:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7d8b260b6049480b74c87735a50427a6da1ccaff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698