Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1719343004: simplify glib condition for including message_pump_glib_unittest.cc (Closed)

Created:
4 years, 10 months ago by Mostyn Bramley-Moore
Modified:
4 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

simplify glib condition for including message_pump_glib_unittest.cc We should use the use_glib variable instead of alternative conditions throughout the build configuration. Committed: https://crrev.com/79a07e3910111030fd5371a3efc0981b55a0277d Cr-Commit-Position: refs/heads/master@{#377053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719343004/1
4 years, 10 months ago (2016-02-23 15:04:30 UTC) #2
Mostyn Bramley-Moore
@brettw: please take a look at this tiny simplification.
4 years, 10 months ago (2016-02-23 15:04:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 15:35:09 UTC) #7
brettw
lgtm
4 years, 10 months ago (2016-02-23 19:10:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719343004/1
4 years, 10 months ago (2016-02-23 19:16:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 19:28:59 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 19:30:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79a07e3910111030fd5371a3efc0981b55a0277d
Cr-Commit-Position: refs/heads/master@{#377053}

Powered by Google App Engine
This is Rietveld 408576698