Move ENABLE_HIDPI to new build flags system

Move ENABLE_HIDPI to new build flags system

This define is only used in one source file.

This takes the flag out of the global build configuration in GN and puts it in a new .gni file in //ui/base that interested parties can import. This flag then controls a define set in the new generated header.

Committed: https://crrev.com/7915ae0dd753d281344d748789818dab97c39a37
Cr-Commit-Position: refs/heads/master@{#377177}

[brettw, 2016-02-23 00:24:35]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2016-02-23 00:42:47]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 00:43:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719343002/1

[sky, 2016-02-23 00:48:58]

LGTM

[commit-bot: I haz the power, 2016-02-23 01:07:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 01:07:57]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-02-23 18:19:19]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-02-23 18:19:19]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1719343002/#ps20001
(title: " ")

[brettw, 2016-02-23 18:19:31]

Description was changed from

==========
Move ENABLE_HIDPI to new build flags system

This define is only used in one source file.

This takes the flag out of the global build configuration in GN abd puts it in a
new .gni file in //ui/base that interested parties can import. This flag then
controls a define set in the new generated header.
==========

to

==========
Move ENABLE_HIDPI to new build flags system

This define is only used in one source file.

This takes the flag out of the global build configuration in GN and puts it in a
new .gni file in //ui/base that interested parties can import. This flag then
controls a define set in the new generated header.
==========

[commit-bot: I haz the power, 2016-02-23 18:20:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719343002/20001

[commit-bot: I haz the power, 2016-02-23 20:28:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 20:28:28]

Failed to apply patch for build/config/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: build/config/BUILD.gn:231
  Falling back to three-way merge...
  Applied patch to 'build/config/BUILD.gn' with conflicts.
  U build/config/BUILD.gn

Patch:       build/config/BUILD.gn
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index
32ec3331e3b3e884e959bed14e61049de86216f4..395d74faa9e591d03330d00cd2ff992ecdac7442
100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -231,9 +231,6 @@ config("feature_flags") {
   if (enable_one_click_signin) {
     defines += [ "ENABLE_ONE_CLICK_SIGNIN" ]
   }
-  if (enable_hidpi) {
-    defines += [ "ENABLE_HIDPI=1" ]
-  }
   if (enable_topchrome_md) {
     defines += [ "ENABLE_TOPCHROME_MD=1" ]
   }

[brettw, 2016-02-23 20:36:42]

merge

[brettw, 2016-02-23 20:38:30]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-02-23 20:38:30]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1719343002/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2016-02-23 20:40:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719343002/40001

[commit-bot: I haz the power, 2016-02-23 22:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 22:47:52]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-02-23 23:46:23]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-02-23 23:48:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719343002/40001

[commit-bot: I haz the power, 2016-02-24 01:25:39]

Description was changed from

==========
Move ENABLE_HIDPI to new build flags system

This define is only used in one source file.

This takes the flag out of the global build configuration in GN and puts it in a
new .gni file in //ui/base that interested parties can import. This flag then
controls a define set in the new generated header.
==========

to

==========
Move ENABLE_HIDPI to new build flags system

This define is only used in one source file.

This takes the flag out of the global build configuration in GN and puts it in a
new .gni file in //ui/base that interested parties can import. This flag then
controls a define set in the new generated header.
==========

[commit-bot: I haz the power, 2016-02-24 01:25:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-24 01:27:59]

Description was changed from

==========
Move ENABLE_HIDPI to new build flags system

This define is only used in one source file.

This takes the flag out of the global build configuration in GN and puts it in a
new .gni file in //ui/base that interested parties can import. This flag then
controls a define set in the new generated header.
==========

to

==========
Move ENABLE_HIDPI to new build flags system

This define is only used in one source file.

This takes the flag out of the global build configuration in GN and puts it in a
new .gni file in //ui/base that interested parties can import. This flag then
controls a define set in the new generated header.

Committed: https://crrev.com/7915ae0dd753d281344d748789818dab97c39a37
Cr-Commit-Position: refs/heads/master@{#377177}
==========

[commit-bot: I haz the power, 2016-02-24 01:28:01]

Patchset 3 (id:??) landed as
https://crrev.com/7915ae0dd753d281344d748789818dab97c39a37
Cr-Commit-Position: refs/heads/master@{#377177}