Add persistent handles to service protocol and Observatory UI

Add persistent handles to service protocol and Observatory UI

VM Changes:

- Add private _getPersistentHandles service RPC.
- Add service_test for _getPersistentHandles.

Observatory Changes:

- Add Persistent Handles page.
- Display persistent handles in a curly-block
- Display weak persistent handles in a sortable table.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/b2249f30fdf09d540cc5e9601aeed605d78a923e

[Cutch, 2016-02-22 22:04:26]

Description was changed from

==========
Add persistent handles to service protocol and Observatory UI

BUG=
==========

to

==========
Add persistent handles to service protocol and Observatory UI

BUG=
==========

[Cutch, 2016-02-22 22:04:26]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-02-22 22:08:41]

Description was changed from

==========
Add persistent handles to service protocol and Observatory UI

BUG=
==========

to

==========
Add persistent handles to service protocol and Observatory UI

VM Changes:

- Add private _getPersistentHandles service RPC.
- Add service_test for _getPersistentHandles.

Observatory Changes:

- Add Persistent Handles page.
- Display persistent handles in a curly-block
- Display weak persistent handles in a sortable table.
==========

[rmacnak, 2016-02-23 20:58:22]

https://chromiumcodereview.appspot.com/1719313002/diff/20001/runtime/observat...
File runtime/observatory/lib/src/elements/persistent_handles.html (right):

https://chromiumcodereview.appspot.com/1719313002/diff/20001/runtime/observat...
runtime/observatory/lib/src/elements/persistent_handles.html:61: <h1>Persistent
Handles</h1>
Persistent Handles (count)

https://chromiumcodereview.appspot.com/1719313002/diff/20001/runtime/observat...
runtime/observatory/lib/src/elements/persistent_handles.html:70:
<any-service-ref ref="{{ persistentHandle['object'] }}">
This page is going to have the same problem as large lists: The object ids of
early elements will be expired on arrival, having been evicted by later
elements.

https://chromiumcodereview.appspot.com/1719313002/diff/20001/runtime/observat...
runtime/observatory/lib/src/elements/persistent_handles.html:79: <h1>Weak
Persistent Handles</h1>
Weak Persistent Handles (count)

https://chromiumcodereview.appspot.com/1719313002/diff/20001/runtime/vm/servi...
File runtime/vm/service.cc (right):

https://chromiumcodereview.appspot.com/1719313002/diff/20001/runtime/vm/servi...
runtime/vm/service.cc:3511: free(name);
NativeSymbolResolver::FreeSymbolName

[Cutch, 2016-02-25 17:23:43]

https://codereview.chromium.org/1719313002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/persistent_handles.html (right):

https://codereview.chromium.org/1719313002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/persistent_handles.html:61: <h1>Persistent
Handles</h1>
On 2016/02/23 20:58:21, rmacnak wrote:
> Persistent Handles (count)

Done.

https://codereview.chromium.org/1719313002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/persistent_handles.html:70:
<any-service-ref ref="{{ persistentHandle['object'] }}">
On 2016/02/23 20:58:22, rmacnak wrote:
> This page is going to have the same problem as large lists: The object ids of
> early elements will be expired on arrival, having been evicted by later
> elements.

Of course, this is a limitation of the service protocol's id system. If we care
we could probably create ids for the persistent handles and then lookup the
object indirectly.

https://codereview.chromium.org/1719313002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/persistent_handles.html:79: <h1>Weak
Persistent Handles</h1>
On 2016/02/23 20:58:21, rmacnak wrote:
> Weak Persistent Handles (count)

Done.

https://codereview.chromium.org/1719313002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1719313002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:3511: free(name);
On 2016/02/23 20:58:22, rmacnak wrote:
> NativeSymbolResolver::FreeSymbolName

Done.

[Cutch, 2016-02-26 14:55:28]

PTAL

[rmacnak, 2016-03-01 00:56:08]

lgtm

[Cutch, 2016-03-01 15:31:34]

Description was changed from

==========
Add persistent handles to service protocol and Observatory UI

VM Changes:

- Add private _getPersistentHandles service RPC.
- Add service_test for _getPersistentHandles.

Observatory Changes:

- Add Persistent Handles page.
- Display persistent handles in a curly-block
- Display weak persistent handles in a sortable table.
==========

to

==========
Add persistent handles to service protocol and Observatory UI

VM Changes:

- Add private _getPersistentHandles service RPC.
- Add service_test for _getPersistentHandles.

Observatory Changes:

- Add Persistent Handles page.
- Display persistent handles in a curly-block
- Display weak persistent handles in a sortable table.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b2249f30fdf09d540cc5e9601aeed605d78a923e
==========

[Cutch, 2016-03-01 15:31:35]

Committed patchset #6 (id:100001) manually as
b2249f30fdf09d540cc5e9601aeed605d78a923e (presubmit successful).