Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1719293002: Make DM failures fatal (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make DM failures fatal We should now only be pushing Srcs for tests that we expect to succeed. So any failures should be treated as errors. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719293002 Committed: https://skia.googlesource.com/skia/+/b65e604f1083e1d0cd85a0635ff4742d95a0837b

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -23 lines) Patch
M dm/DM.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M dm/DMSrcSink.cpp View 4 chunks +10 lines, -23 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719293002/1
4 years, 10 months ago (2016-02-22 21:16:02 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/6384)
4 years, 10 months ago (2016-02-22 21:29:25 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719293002/20001
4 years, 10 months ago (2016-02-22 21:46:29 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-22 22:10:30 UTC) #10
msarett
4 years, 10 months ago (2016-02-22 22:11:57 UTC) #12
scroggo
lgtm
4 years, 10 months ago (2016-02-23 00:59:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719293002/20001
4 years, 10 months ago (2016-02-23 13:36:35 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 13:37:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b65e604f1083e1d0cd85a0635ff4742d95a0837b

Powered by Google App Engine
This is Rietveld 408576698