components: Rename component_resources.* to autofill_strings.*

components: Rename component_resources.* to component_strings.*

components_resources is misleading. Resources are generally images/assets
and/or html/js/css files and we use IDR_* for them.

BUG=250213
R=joi@chromium.org, thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207130

[tfarina, 2013-06-17 01:59:35]

Hi Joi, please take a look.

Thanks,

[Cait (Slow), 2013-06-17 02:20:00]

Hi Thiago,

Thanks for tackling this. Note that (although it only contains Autofill strings
currently), this file is intended to contain any strings needed for all
components. Joi and I discussed having one .grd per component, but decided
against it due to the build-time cost added by each invocation of GRIT.  That
said, it maybe it would be best to leave it in the top-level components
directory and change the name to component_strings.grd?

Cheers,
Cait

[tfarina, 2013-06-17 02:25:39]

On Sun, Jun 16, 2013 at 11:20 PM,  <caitkp@chromium.org> wrote:
> Hi Thiago,
>
> Thanks for tackling this. Note that (although it only contains Autofill
> strings
> currently), this file is intended to contain any strings needed for all
> components. Joi and I discussed having one .grd per component, but decided
> against it due to the build-time cost added by each invocation of GRIT.
> That
> said, it maybe it would be best to leave it in the top-level components
> directory and change the name to component_strings.grd?
>
Sure, it's fine by me. I'll probably move then it to
components/strings/component_strings.* so. I'll wait for Joi's input
to make this change though.

May be another solution would be to have component_strings.grd and
part files (autofill_strings.grdp)?

-- 
Thiago

[Jói, 2013-06-17 08:42:00]

I think it should simply be //components/components_strings.grd.
Using *.grp files is a good idea though.

Cheers,
Jói


On Mon, Jun 17, 2013 at 2:25 AM, Thiago Farina <tfarina@chromium.org> wrote:
> On Sun, Jun 16, 2013 at 11:20 PM,  <caitkp@chromium.org> wrote:
>> Hi Thiago,
>>
>> Thanks for tackling this. Note that (although it only contains Autofill
>> strings
>> currently), this file is intended to contain any strings needed for all
>> components. Joi and I discussed having one .grd per component, but decided
>> against it due to the build-time cost added by each invocation of GRIT.
>> That
>> said, it maybe it would be best to leave it in the top-level components
>> directory and change the name to component_strings.grd?
>>
> Sure, it's fine by me. I'll probably move then it to
> components/strings/component_strings.* so. I'll wait for Joi's input
> to make this change though.
>
> May be another solution would be to have component_strings.grd and
> part files (autofill_strings.grdp)?
>
> --
> Thiago
>
> --
> You received this message because you are subscribed to the Google Groups
"browser-components-watch" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to browser-components-watch+unsubscribe@chromium.org.
> To post to this group, send email to browser-components-watch@chromium.org.
> To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/browser-components-watch/CAF....
> For more options, visit
https://groups.google.com/a/chromium.org/groups/opt_out.
>
>

[Jói, 2013-06-17 08:48:36]

Also note:  Any name change needs to happen ASAP since there is a
branch point next Monday and we need to make the change before then
and twiddle some Google-internal bits after that.

On Mon, Jun 17, 2013 at 8:41 AM, Jói Sigurðsson <joi@chromium.org> wrote:
> I think it should simply be //components/components_strings.grd.
> Using *.grp files is a good idea though.
>
> Cheers,
> Jói
>
>
> On Mon, Jun 17, 2013 at 2:25 AM, Thiago Farina <tfarina@chromium.org> wrote:
>> On Sun, Jun 16, 2013 at 11:20 PM,  <caitkp@chromium.org> wrote:
>>> Hi Thiago,
>>>
>>> Thanks for tackling this. Note that (although it only contains Autofill
>>> strings
>>> currently), this file is intended to contain any strings needed for all
>>> components. Joi and I discussed having one .grd per component, but decided
>>> against it due to the build-time cost added by each invocation of GRIT.
>>> That
>>> said, it maybe it would be best to leave it in the top-level components
>>> directory and change the name to component_strings.grd?
>>>
>> Sure, it's fine by me. I'll probably move then it to
>> components/strings/component_strings.* so. I'll wait for Joi's input
>> to make this change though.
>>
>> May be another solution would be to have component_strings.grd and
>> part files (autofill_strings.grdp)?
>>
>> --
>> Thiago
>>
>> --
>> You received this message because you are subscribed to the Google Groups
"browser-components-watch" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
email to browser-components-watch+unsubscribe@chromium.org.
>> To post to this group, send email to browser-components-watch@chromium.org.
>> To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/browser-components-watch/CAF....
>> For more options, visit
https://groups.google.com/a/chromium.org/groups/opt_out.
>>
>>

[tfarina, 2013-06-17 22:37:42]

Done. Please, take another look.

[Jói, 2013-06-18 09:52:35]

LGTM

[tfarina, 2013-06-18 11:57:52]

+Lei for chrome/

[Lei Zhang, 2013-06-18 17:58:33]

lgtm

[commit-bot: I haz the power, 2013-06-18 18:24:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/17192004/22001

[commit-bot: I haz the power, 2013-06-18 18:24:55]

Failed to apply patch for components/autofill/browser/autofill_profile.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file components/autofill/browser/autofill_profile.cc
  Hunk #1 FAILED at 23.
  1 out of 1 hunk FAILED -- saving rejects to file
components/autofill/browser/autofill_profile.cc.rej

Patch:       components/autofill/browser/autofill_profile.cc
Index: components/autofill/browser/autofill_profile.cc
diff --git a/components/autofill/browser/autofill_profile.cc
b/components/autofill/browser/autofill_profile.cc
index
82e0e689f35ae3aa2f3fdb1708eacec24dc394cb..f16a41445d4c819d7ee48b515083dbae18a7f86b
100644
--- a/components/autofill/browser/autofill_profile.cc
+++ b/components/autofill/browser/autofill_profile.cc
@@ -23,7 +23,7 @@
 #include "components/autofill/browser/phone_number.h"
 #include "components/autofill/browser/phone_number_i18n.h"
 #include "components/autofill/common/form_field_data.h"
-#include "grit/component_resources.h"
+#include "grit/component_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace autofill {

[tfarina, 2013-06-19 00:52:11]

Committed patchset #5 manually as r207130 (presubmit successful).