Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1837)

Issue 1719193002: Remove triple-shift from dart2js. (Closed)

Created:
4 years, 10 months ago by floitsch
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org, ahe
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
floitsch
4 years, 10 months ago (2016-02-22 18:24:07 UTC) #2
Siggi Cherem (dart-lang)
lgtm Every day learn something new. I didn't know this wasn't part of Dart
4 years, 10 months ago (2016-02-22 18:51:32 UTC) #3
floitsch
On 2016/02/22 18:51:32, Siggi Cherem (dart-lang) wrote: > lgtm > > Every day learn something ...
4 years, 10 months ago (2016-02-23 10:21:03 UTC) #4
floitsch
Committed patchset #1 (id:1) manually as 3df7b0c072ede3ca3ddd866bb713a8b5a9e1d794 (presubmit successful).
4 years, 10 months ago (2016-02-23 10:21:16 UTC) #6
ahe
4 years, 10 months ago (2016-02-23 11:31:21 UTC) #8
Message was sent while issue was closed.
LGTM, this was already removed from the scanner.

Powered by Google App Engine
This is Rietveld 408576698