Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: content/browser/cache_storage/cache_storage_cache.h

Issue 1719103002: CacheStorage: Expand cache.keys() method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/cache_storage/cache_storage_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/cache_storage/cache_storage_cache.h
diff --git a/content/browser/cache_storage/cache_storage_cache.h b/content/browser/cache_storage/cache_storage_cache.h
index 97e7455b75d5ba0bb5a023790b1ca7eae8276b6c..c5e44e20047a413fc5b51c5e72be37c4d0139b4f 100644
--- a/content/browser/cache_storage/cache_storage_cache.h
+++ b/content/browser/cache_storage/cache_storage_cache.h
@@ -133,9 +133,10 @@ class CONTENT_EXPORT CacheStorageCache {
CacheStorageError error);
void BatchDidAllOperations(std::unique_ptr<ErrorCallback> callback);
- // TODO(jkarlin): Have keys take an optional ServiceWorkerFetchRequest.
// Returns CACHE_STORAGE_OK and a vector of requests if there are no errors.
- void Keys(const RequestsCallback& callback);
+ void Keys(std::unique_ptr<ServiceWorkerFetchRequest> request,
+ const CacheStorageCacheQueryParams& options,
+ const RequestsCallback& callback);
// Closes the backend. Future operations that require the backend
// will exit early. Close should only be called once per CacheStorageCache.
@@ -319,7 +320,9 @@ class CONTENT_EXPORT CacheStorageCache {
int rv);
// Keys callbacks.
- void KeysImpl(const RequestsCallback& callback);
+ void KeysImpl(std::unique_ptr<ServiceWorkerFetchRequest> request,
+ const CacheStorageCacheQueryParams& options,
+ const RequestsCallback& callback);
void KeysDidQueryCache(
const RequestsCallback& callback,
CacheStorageError error,
« no previous file with comments | « no previous file | content/browser/cache_storage/cache_storage_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698