build/gyp_chromium - Issue 171903002: android envsetup: Stop honoring --target-arch parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_chromium

Issue 171903002: android envsetup: Stop honoring --target-arch parameter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_chromium

diff --git a/build/gyp_chromium b/build/gyp_chromium

index e4cafc756134c35dc51c7ec3ea111bfef5157653..ae1d4c2f66242d7c883b990078479bfd92f86836 100755

--- a/build/gyp_chromium

+++ b/build/gyp_chromium

@@ -177,6 +177,11 @@ def GetArgsStringForGN(supplemental_files):

supplemental_files += [include_gypi]

vars_dict = GetGypVarsForGN(supplemental_files)

+ # It's not possible to let set a default value for cpu_arch in GN, so do it

+ # here for now (http://crbug.com/344767).

+ if vars_dict.get('OS') == 'android' and not 'target_arch' in vars_dict:

+ vars_dict['target_arch'] = 'arm'

gn_args = ''

# Note: These are the additional flags passed to various builds by builders