Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: build/gyp_chromium

Issue 171903002: android envsetup: Stop honoring --target-arch parameter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 # This script is wrapper for Chromium that adds some support for how GYP 7 # This script is wrapper for Chromium that adds some support for how GYP
8 # is invoked by Chromium beyond what can be done in the gclient hooks. 8 # is invoked by Chromium beyond what can be done in the gclient hooks.
9 9
10 import glob 10 import glob
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 home_dot_gyp = None 170 home_dot_gyp = None
171 else: 171 else:
172 break 172 break
173 173
174 if home_dot_gyp: 174 if home_dot_gyp:
175 include_gypi = os.path.join(home_dot_gyp, "include.gypi") 175 include_gypi = os.path.join(home_dot_gyp, "include.gypi")
176 if os.path.exists(include_gypi): 176 if os.path.exists(include_gypi):
177 supplemental_files += [include_gypi] 177 supplemental_files += [include_gypi]
178 178
179 vars_dict = GetGypVarsForGN(supplemental_files) 179 vars_dict = GetGypVarsForGN(supplemental_files)
180 # It's not possible to let set a default value for cpu_arch in GN, so do it
181 # here for now (http://crbug.com/344767).
182 if vars_dict.get('OS') == 'android' and not 'target_arch' in vars_dict:
183 vars_dict['target_arch'] = 'arm'
184
180 gn_args = '' 185 gn_args = ''
181 186
182 # Note: These are the additional flags passed to various builds by builders 187 # Note: These are the additional flags passed to various builds by builders
183 # on the main waterfall. We'll probably need to add these at some point: 188 # on the main waterfall. We'll probably need to add these at some point:
184 # mac_strip_release=1 http://crbug.com/330301 189 # mac_strip_release=1 http://crbug.com/330301
185 # linux_dump_symbols=0 http://crbug.com/330300 190 # linux_dump_symbols=0 http://crbug.com/330300
186 # host_os=linux Probably can skip, GN knows the host OS. 191 # host_os=linux Probably can skip, GN knows the host OS.
187 # order_text_section=<path> http://crbug.com/330299 192 # order_text_section=<path> http://crbug.com/330299
188 # chromium_win_pch=0 http://crbug.com/297678 193 # chromium_win_pch=0 http://crbug.com/297678
189 # chromium_ios_signing=0 http://crbug.com/330302 194 # chromium_ios_signing=0 http://crbug.com/330302
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 # rather than a separate runhooks step so that any environment modifications 496 # rather than a separate runhooks step so that any environment modifications
492 # from above are picked up. 497 # from above are picked up.
493 print 'Running build/landmines.py...' 498 print 'Running build/landmines.py...'
494 subprocess.check_call( 499 subprocess.check_call(
495 [sys.executable, os.path.join(script_dir, 'landmines.py')]) 500 [sys.executable, os.path.join(script_dir, 'landmines.py')])
496 501
497 if vs2013_runtime_dll_dirs: 502 if vs2013_runtime_dll_dirs:
498 CopyVsRuntimeDlls(GetOutputDirectory(), vs2013_runtime_dll_dirs) 503 CopyVsRuntimeDlls(GetOutputDirectory(), vs2013_runtime_dll_dirs)
499 504
500 sys.exit(gyp_rc) 505 sys.exit(gyp_rc)
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | tools/cr/cr/base/android.py » ('j') | tools/cr/cr/base/android.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698