Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1719003005: MIPS64: [fullcodegen] Implement operand stack depth tracking. (Closed)

Created:
4 years, 10 months ago by balazs.kilvady
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: [fullcodegen] Implement operand stack depth tracking. Port for https://codereview.chromium.org/1706283002/ Original commit message: This implements a mechanism to track the exact depth of the operand stack in full-codegen for every sub-expression visitation. So far we only tracked the depth at statement level, but not at expression level. With the introduction of do-expressions it will be possible to construct local control flow (i.e. break, continue and friends) that target labels at an arbitrary operand stack depth, making this tracking a prerequisite for full do-expression support. BUG=v8:4755, v8:4488 LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -107 lines) Patch
M src/full-codegen/mips64/full-codegen-mips64.cc View 79 chunks +152 lines, -107 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
balazs.kilvady
Description was changed from ========== MIPS64: [fullcodegen] Implement operand stack depth tracking. Port for https://codereview.chromium.org/1706283002/ ...
4 years, 10 months ago (2016-02-23 12:38:26 UTC) #1
balazs.kilvady
balazs.kilvady@imgtec.com changed reviewers: - jarin@chromium.org, rossberg@chromium.org
4 years, 10 months ago (2016-02-23 12:38:27 UTC) #2
balazs.kilvady
4 years, 10 months ago (2016-02-23 12:39:45 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698