Clear reserved flags on synthetic continuations.

Clear reserved flags on synthetic continuations.

Previously when WebSocketBasicStream split a frame that arrived in
several chunks, it would copy the reserved bits from the first frame
onto all subsequent frames.

However, the permessage-deflate extension requires that the RSV1 bit
only be set on the first frame of the message.

For compatability with permessage-deflate, clear the reserved bits on
second and subsequent frames when splitting a frame.

BUG=343507
TEST=net_unittests --gtest_filter=WebSocket*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252000

[tyoshino (SeeGerritForStatus), 2014-02-19 05:19:19]

lgtm

https://codereview.chromium.org/171883002/diff/1/net/websockets/websocket_bas...
File net/websockets/websocket_basic_stream.cc (right):

https://codereview.chromium.org/171883002/diff/1/net/websockets/websocket_bas...
net/websockets/websocket_basic_stream.cc:385: if (!is_final_chunk &&
WebSocketFrameHeader::IsKnownDataOpCode(opcode)) {
addition of !is_final_chunk is just a small optimization?

[Adam Rice, 2014-02-19 05:26:13]

https://codereview.chromium.org/171883002/diff/1/net/websockets/websocket_bas...
File net/websockets/websocket_basic_stream.cc (right):

https://codereview.chromium.org/171883002/diff/1/net/websockets/websocket_bas...
net/websockets/websocket_basic_stream.cc:385: if (!is_final_chunk &&
WebSocketFrameHeader::IsKnownDataOpCode(opcode)) {
On 2014/02/19 05:19:19, tyoshino wrote:
> addition of !is_final_chunk is just a small optimization?

Yes, exactly.

[Adam Rice, 2014-02-19 05:26:22]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2014-02-19 05:26:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/171883002/1

[commit-bot: I haz the power, 2014-02-19 08:27:49]

Change committed as 252000