Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 1718803002: Make StringSource fully implement Source (issue 25822) (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make StringSource fully implement Source (issue 25822) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c8a3ede9022846af88df4bc88068936d357af709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M pkg/analyzer/lib/src/string_source.dart View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-20 18:10:57 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-20 22:50:15 UTC) #3
Brian Wilkerson
4 years, 10 months ago (2016-02-21 15:55:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8a3ede9022846af88df4bc88068936d357af709 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698